Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix repository URLs in packages #242

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

zeke
Copy link
Contributor

@zeke zeke commented Jul 3, 2017

packages → modules

screen shot 2017-07-03 at 11 23 55 am

cc @broccolini

@broccolini
Copy link
Member

Thanks @zeke - that's actually only one of the packages and not the actual primer-css package. And all of the packages should be updated to correct this url! Since we'll need to cut a new release I've pulled your pr into a dev branch as we may want to include a few other additions before cutting a new release. Thanks for spotting this one though!

@zeke
Copy link
Contributor Author

zeke commented Jul 4, 2017

that's actually only one of the packages

oops thought I did a global search and replace 🙈

Feel free to close this out then 👍

@zeke
Copy link
Contributor Author

zeke commented Jul 7, 2017

thought I did a global search and replace

Figured it out. I switched from Atom to VSCode which doesn't save search-and-replace changes automatically by default.

I went ahead and updated the PR to fix all URLs just in case you still need it.

@shawnbot shawnbot changed the base branch from master to dev July 7, 2017 20:44
@shawnbot
Copy link
Contributor

shawnbot commented Jul 7, 2017

I changed the base to merge this to dev. Thanks, @zeke!

@shawnbot shawnbot merged commit 41e0169 into dev Jul 7, 2017
@shawnbot shawnbot deleted the fix-repository-urls-in-packages branch July 7, 2017 20:45
@broccolini
Copy link
Member

@shawnbot fyi I pulled this into my pr #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants