Dev branch for new release #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broccolini
dismissed
shawnbot’s stale review
This pr wasn't ready for review, I've made major updates since so needs to be reviewed again.
|
Published |
- primer-alerts@1.1.8 - primer-avatars@1.0.2 - primer-base@1.1.5 - primer-blankslate@1.0.2 - primer-box@2.1.8 - primer-breadcrumb@1.0.2 - primer-buttons@2.0.6 - primer-cards@0.1.8 - primer-core@6.0.0 - primer-css@9.0.0 - primer-forms@1.0.13 - primer-labels@1.1.6 - primer-layout@1.0.5 - primer-markdown@3.3.13 - primer-marketing-support@1.0.2 - primer-marketing-type@1.0.2 - primer-marketing-utilities@1.0.2 - primer-marketing@5.0.2 - primer-navigation@1.0.6 - primer-page-headers@1.0.2 - primer-page-sections@1.0.2 - primer-product@5.0.2 - primer-support@4.0.7 - primer-table-object@1.0.9 - primer-tables@1.0.2 - primer-tooltips@1.0.2 - primer-truncate@1.0.2 - primer-utilities@4.3.5
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr:
packagestomodulesdevandrcpublish scripts to--skip-gitsince we're unlikely to want them to publish tags, and I removed the script for regular publishing and skipping git as in the majority of cases we'll want to publish git tags with releasesUpdate ❗️
I noticed some odd quirks while working on the new style guide and discovered that we are not pulling in the latest version of
primer-baseinprimer-coreandprimer-css. We're currently pointing to0.4.0which is the version before we added our own normalize to base 😱 . This may explain some of the odd issues we're finding on GitHub.com.I'll open a pr in github/github to bump the version which I'll ship asap on Monday as soon as both pr's are reviewed.