-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting the dev branch workflow instructions #513
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
- [ ] First, change the base branch from "master" to "dev". | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the base branch here be the release branch? Since we merge into the release branch first There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Schwoops, forgot to submit my review so this comment is just now showing up - but saw your last comment so feel free to ignore this 👍 |
||
|
||
- [ ] Next, briefly describe your proposal in the title. | ||
- [ ] First, briefly describe your proposal in the title. | ||
|
||
- [ ] Fixes: # (type an issue number after the # if applicable) | ||
|
||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
open a pull request against the latest release branch
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think contributors should have to make that decision. I'd rather they just be open against the default and the core team decide which release branch they fall into.