Deleting the dev branch workflow instructions #513
Conversation
| 4. Make your changes and commit them. | ||
| 5. Push your branch and open a pull request against `dev`. Add a comment describing your proposed changes and request a review from `@primer/ds-core`. | ||
| 5. Push your branch and open a pull request. Add a comment describing your proposed changes and request a review from `@primer/ds-core`. |
There was a problem hiding this comment.
Should this be open a pull request against the latest release branch?
There was a problem hiding this comment.
I don't think contributors should have to make that decision. I'd rather they just be open against the default and the core team decide which release branch they fall into.
|
Whenever this goes through I'll happily adjust my PR 😆 Just didn't feel right using |
|
@austinpaquette No worries, we're making adjustments I can take what you sent and run with it. Thanks! |
| @@ -1,6 +1,4 @@ | |||
| - [ ] First, change the base branch from "master" to "dev". | |||
There was a problem hiding this comment.
Should the base branch here be the release branch? Since we merge into the release branch first
There was a problem hiding this comment.
Schwoops, forgot to submit my review so this comment is just now showing up - but saw your last comment so feel free to ignore this 👍
Fixes #512
In this pull request I aimed to correct any contributing docs and scripts that might reference the dead
devbranch.RELEASING.mdfile, I decided that making release instructions part of theCONTRIBUTING.mdfile was better.CONTRIBUTING.mdand corrected anything that might not make sense anymore./cc @primer/ds-core