Add btn-transparent back in #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
re-requesting a review as i added one more edit to this PR! changed currently it has a white bg like this below |
shawnbot
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Looks good! Turns out, I need this to test #671 on dot-com because there are still some instances of btn-transparent on the Save Net Neutrality page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Woops! I took out
btn-transparentwhen i added the new marketing buttons but in hindsight this is still super useful for one-off contexts where we have a dark background and need a white button. Plus it is still used on a few jekyll sites./cc @primer/ds-core @sophshep