Release 12.0.0 #671
Merged
Release 12.0.0 #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: primer is now @primer/css
emplums
reviewed
Feb 14, 2019
Co-Authored-By: shawnbot <shawn.allen@github.com>
jonrohan
approved these changes
Feb 19, 2019
emplums
reviewed
Feb 19, 2019
| "lint": "stylelint --quiet --syntax scss src/**/*.scss", | ||
| "lint-js": "eslint lib docs", | ||
| "now-build": "next build", | ||
| "now-start": "next start", |
There was a problem hiding this comment.
Could you make these consistent with the other repositories so that it's easier to jump in and contribute? Most of the other repos call this dev, etc without the now prefix
There was a problem hiding this comment.
I was hoping that these could be the new standard because it makes it possible for npm start to do the right thing locally (run the dev server) and Now does its own thing. I've added an "alias" so that npm run dev does the same thing as npm start for now, though.
This was referenced Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primer Major Release
Version: 📦 12.0.0
Approximate release date: 📆 Feb 15, 2019
Docs preview: primer-css-release-12-0-0.now.sh
💥 Breaking Change
@primer/cssReorganize the packages 🤘 #666 (see [Tracking] Package reorganization #653 for tracking)🚀 Enhancement
@primer/css/postcss.config)primer-migratescript for updating Sass import paths Add primer-migrate script #677🐛 Bug fix
btn-transparentin marketing buttons Add btn-transparent back in #668📝 Documentation
DEVELOP.md(see: todos)MIGRATING.mdREADME.mdRELEASING.md🏠 Internal
Ship checklist
package.jsonwithnpm versionCHANGELOG.md/cc @primer/ds-core