Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <details> spacing #675

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Fix <details> spacing #675

merged 2 commits into from
Mar 13, 2019

Conversation

mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Feb 13, 2019

This fixes <details> spacing in markdown.

  • First, briefly describe your proposal in the title.

<details> in markdown does not have a margin bottom, even though it should have one. Demo:

Note how this text is directly below the details element without the proper bottom margin. I always end up putting a <br> below the details to make it look correct.

Note that this is completely untested. 😅

/cc @primer/ds-core

This fixes &lt;details &gt; spacing in markdown
Copy link

@mikekavouras mikekavouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have no authority here but good work

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @mxstbr! I'd like to include this in the next release after we wrap up #671. 🍻

@simurai simurai mentioned this pull request Mar 12, 2019
10 tasks
@simurai simurai changed the base branch from master to release-12.2.0 March 12, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants