-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade stylelint-config-primer, lint all the things #960
Conversation
Fix broken links to typography utilities
Fix Box--overlay example
Publish variables.json
Update development docs for new gatsby site
Add TODO@version stylelint rule (local)
Add IssueLabel component
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/kx5gv14vv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
I assume all the changes currently on the release-13.2.0
branch need fixing too? Maybe that can be done on that branch directly, after merging this.
I'm (re)doing this over in #968. |
This PR will modernize our styleint setup and get it aligned with github/github once v9.0 is released in primer/stylelint-config#53. Here's the deal:
npx stylelint-only 'primer/*' -- --fix src
to auto-fix all the new (to this repo) rulesnpx stylelint-disable primer/{colors,borders,spacing,box-shadow,typography} -- src
to addstylelint-disable
comments for existing violations that can't be auto-fixednpm i stylelint-config-primer@9
Once this is merged, we will be enforcing all of the same rules in this repo as we do in github/github. We're not currently tracking the violations here, but it's easy enough to either search for
stylelint-disable
comments for the rules we're looking to fix up, or usestylelint-only
:In a future PR I'm going to introduce a standalone version of the stylelint spreadsheet formatter so that we can generate the same types of "reports" here that we do in github/github. 🤓