Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stylelint-config-primer, lint all the things #960

Closed
wants to merge 31 commits into from

Conversation

shawnbot
Copy link
Contributor

This PR will modernize our styleint setup and get it aligned with github/github once v9.0 is released in primer/stylelint-config#53. Here's the deal:

Once this is merged, we will be enforcing all of the same rules in this repo as we do in github/github. We're not currently tracking the violations here, but it's easy enough to either search for stylelint-disable comments for the rules we're looking to fix up, or use stylelint-only:

npx stylelint-only primer/colors -- --quiet src

In a future PR I'm going to introduce a standalone version of the stylelint spreadsheet formatter so that we can generate the same types of "reports" here that we do in github/github. 🤓

Emily and others added 30 commits September 13, 2019 12:03
Fix broken links to typography utilities
Update development docs for new gatsby site
Add TODO@version stylelint rule (local)
@shawnbot shawnbot requested a review from simurai October 24, 2019 17:42
@vercel
Copy link

vercel bot commented Oct 24, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/kx5gv14vv
🌍 Preview: https://primer-css-git-stylelint-upgrade.primer.now.sh

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I assume all the changes currently on the release-13.2.0 branch need fixing too? Maybe that can be done on that branch directly, after merging this.

@shawnbot shawnbot mentioned this pull request Oct 25, 2019
15 tasks
@shawnbot shawnbot changed the base branch from release-13.2.0 to master October 25, 2019 16:49
@shawnbot
Copy link
Contributor Author

shawnbot commented Nov 1, 2019

I'm (re)doing this over in #968.

@shawnbot shawnbot closed this Nov 1, 2019
@shawnbot shawnbot deleted the stylelint-upgrade branch November 1, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants