-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applies .selected styles to [aria-selected=true] #982
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/cv40nbw7f |
This is great, thank you @flavianunes! ❤️ Our team is a bit busy with Universe and planning this week, but I will take a look at this as soon as I can. We don't have a minor release scheduled at this time, but I would love for this to be included in #925 (v14.0) unless we have a good reason to release before then. |
Oops, I committed some other issue in the same branch, sorry! I will divide this in two PRs later |
I have fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flavianunes Thanks for contributing. 🙇
👍 I'll merge this already into #1006 so we can test CI and also update the docs.
I picked the first option from @shawnbot suggestions for its simplicity.
/cc @primer/ds-core