Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies .selected styles to [aria-selected=true] #982

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

flavianunes
Copy link
Contributor

I picked the first option from @shawnbot suggestions for its simplicity.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Nov 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/cv40nbw7f
🌍 Preview: https://primer-css-git-fork-flavianunes-master.primer.now.sh

@shawnbot
Copy link
Contributor

This is great, thank you @flavianunes! ❤️

Our team is a bit busy with Universe and planning this week, but I will take a look at this as soon as I can. We don't have a minor release scheduled at this time, but I would love for this to be included in #925 (v14.0) unless we have a good reason to release before then.

@flavianunes
Copy link
Contributor Author

Oops, I committed some other issue in the same branch, sorry! I will divide this in two PRs later

@flavianunes
Copy link
Contributor Author

Oops, I committed some other issue in the same branch, sorry! I will divide this in two PRs later

I have fixed it

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavianunes Thanks for contributing. 🙇

👍 I'll merge this already into #1006 so we can test CI and also update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants