Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces .disabled with :disabled and [disabled] #983

Closed
wants to merge 1 commit into from

Conversation

flavianunes
Copy link
Contributor

As @shawnbot suggested, I replaced .disabled with both :disabled and [disabled].

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Nov 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/9bkr1ld3k
🌍 Preview: https://primer-css-git-fork-flavianunes-a11yfix.primer.now.sh

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. 👍 Thanks @flavianunes. 🙇


@shawnbot Since there are probably a lot of places on github/github that we would need to update, should we test this first with an RC from this PR and only once everything is ok, merge this PR into 14.0.0 or 15.0.0?

And by "this PR", I mean merge the changes into a new branch/PR on this repo so that the publish script works.

@shawnbot
Copy link
Contributor

Thank you for this, @flavianunes! @simurai, I think we should hold off on releasing this until the next major release (15.0.0). We've got a lot that needs to change already, and with custom properties on the horizon we've got plenty to queue up already.

@simurai
Copy link
Contributor

simurai commented Dec 31, 2019

An alternative to this PR could be using [aria-disabled=true], see #791 (comment)

And because currently .disabled gets used a lot, as a first step we could only add [aria-disabled=true] and update the docs. Similar to #982. And later remove .disabled once we cleaned up all the uses on dotcom.

@simurai simurai mentioned this pull request Jan 3, 2020
2 tasks
@simurai simurai closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace .disabled with :disabled and/or [disabled]
3 participants