Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MarkdownEditor.Footer support in direct-slot-children rule #74

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

TylerJDev
Copy link
Contributor

Summary

Adds support for MarkdownEditor.Footer.

MarkdownEditor.Footer was recently added to the MarkdownEditor component and the direct-slot-children rule has not yet been updated to reflect that. This PR adds support for MarkdownEditor.Actions and MarkdownEditor.FooterButton under MarkdownEditor.Footer.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: c07df5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TylerJDev TylerJDev requested review from a team and joshblack August 4, 2023 17:20
@siddharthkp
Copy link
Member

siddharthkp commented Aug 4, 2023

Non blocker: Is there a way we could read these from a peer dependency of @primer/react?

Feels awkward to have to keep syncing between primer/react and eslint-plugin-primer-react

@TylerJDev
Copy link
Contributor Author

TylerJDev commented Aug 4, 2023

Non blocker: Is there a way we could read these from a peer dependency of @primer/react?

I would love if we could do this! I'm not entirely sure how though, unless we move this mapping into primer/react itself. Wondering if there's an alternative way to go about this.

Edit: Will loop back to this! I think we could potentially add something here, but will require coordination from @primer/react

@TylerJDev TylerJDev merged commit 6fef8bb into main Aug 7, 2023
@TylerJDev TylerJDev deleted the tylerjdev/adjust-direct-slot-children-rule branch August 7, 2023 20:19
@primer-css primer-css mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants