Bump eslint-plugin-primer-react
#3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
size-limit report 📦
|
TylerJDev
commented
Aug 4, 2023
| @@ -261,6 +261,7 @@ describe('MarkdownEditor', () => { | |||
| it('renders custom action buttons', async () => { | |||
| const {getActionButton} = await render( | |||
| <UncontrolledEditor> | |||
| {/* eslint-disable-next-line primer-react/direct-slot-children */} | |||
There was a problem hiding this comment.
UncontrolledEditor is MarkdownEditor but exists under UncontrolledEditor, which the linter does not know. Since this is only used in a test, I added inline disables to each test case that utilizes it.
joshblack
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite: primer/eslint-plugin-primer-react#74
Bumps
eslint-plugin-primer-reactto4.0.x.This PR brings us to
4.0.xfrom2.0.3.direct-slot-childrenruleMerge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.