Merge pull request #154 from primer/jules-HC-avatar-and-diffstat-borders

Improved HC avatar and diffstat borders
primer · Jun 22, 2021 · b0e250d · b0e250d
2 parents e44ba7b + a4aff36
commit b0e250d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 5 deletions.
diff --git a/.changeset/little-boats-do.md b/.changeset/little-boats-do.md
@@ -0,0 +1,5 @@
+---
+"@primer/primitives": patch
+---
+
+Update hc avatar and diffstat borders
diff --git a/data/colors_v2/themes/dark_high_contrast.ts b/data/colors_v2/themes/dark_high_contrast.ts
@@ -124,6 +124,16 @@ const exceptions = {
     muted: get('scale.gray.5'),
     subtle: get('scale.gray.5')
   },
+  avatar: {
+    border: alpha(get('scale.white'), 0.9),
+  },
+  diffstat: {
+    deletionBorder: get('scale.red.2'),
+    additionBorder: get('scale.green.2')
+  },
+  neutral: {
+    emphasis: get('scale.gray.6')
+  },
   btn: {
     primary: {
       text: get('scale.gray.9'),

diff --git a/data/colors_v2/vars/component_dark.ts b/data/colors_v2/vars/component_dark.ts
@@ -3,10 +3,15 @@ import {alpha, darken, get} from '../../../src/utils'
 export default {
   avatar: {
     bg: alpha(get('scale.white'), 0.1),
+    border: get('border.subtle'),
     stackFade: get('scale.gray.6'),
     stackFadeMore: get('scale.gray.7'),
     childShadow: (theme: any) => `-2px -2px 0 ${get('scale.gray.9')(theme)}`
   },
+  diffstat: {
+    deletionBorder: get('border.subtle'),
+    additionBorder: get('border.subtle'),
+  },
   selectMenu: {
     backdropBorder: get('scale.gray.5'),
     tapHighlight: alpha(get('scale.gray.6'), 0.5),

diff --git a/data/colors_v2/vars/component_light.ts b/data/colors_v2/vars/component_light.ts
@@ -3,10 +3,15 @@ import {alpha, darken, get} from '../../../src/utils'
 export default {
   avatar: {
     bg: get('scale.white'),
+    border: get('border.subtle'),
     stackFade: get('scale.gray.3'),
     stackFadeMore: get('scale.gray.2'),
     childShadow: (theme: any) => `-2px -2px 0 ${alpha(get('scale.white'), 0.8)(theme)}`
   },
+  diffstat: {
+    deletionBorder: get('border.subtle'),
+    additionBorder: get('border.subtle'),
+  },
   selectMenu: {
     backdropBorder: 'transparent',
     tapHighlight: alpha(get('scale.gray.3'), 0.5),

diff --git a/data/colors_v2/vars/deprecated.ts b/data/colors_v2/vars/deprecated.ts
@@ -252,9 +252,6 @@ export default {
       bg: get('neutral.subtle')
     }
   },
-  avatar: {
-    border: get('border.subtle'),
-  },
   box: {
     blueBorder: get('accent.muted'),
     rowYellowBg: get('attention.subtle'),
@@ -451,9 +448,7 @@ export default {
     neutralBg: get('neutral.muted'),
     neutralBorder: get('border.subtle'),
     deletionBg: get('danger.emphasis'),
-    deletionBorder: get('border.subtle'),
     additionBg: get('success.emphasis'),
-    additionBorder: get('border.subtle'),
   },
   diff: {
     addition: {