Jules hc avatar and diffstat borders #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'border.subtle' doesn’t work on Avatars and +/- diffstats. Therefore I made two exceptions.
🦋 Changeset detectedLatest commit: a4aff36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/HcEZcu13kC2qb3yENCnQyqRKB3PY |
simurai
reviewed
Jun 17, 2021
There was a problem hiding this comment.
Same as #153 (comment). We plan to replace these variables with global variables.
simurai
approved these changes
Jun 22, 2021
….com/primer/primitives into jules-HC-avatar-and-diffstat-borders
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
border.subtledoesn’t work on Avatars and +/- diffstats since in both cases it’s too dark. Therefore I made two exceptions to keep border.subtle the same as border default and muted.