Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primer.fg.disabled #252

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Add primer.fg.disabled #252

merged 2 commits into from
Oct 1, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 1, 2021

This adds the primer.fg.disabled variable. It's meant to be used for disabled text. See https://github.com/github/primer/issues/292 for more details.

The primer is used to stay undocumented and mostly be used for components like buttons, text inputs etc.

Light Dark
Screen Shot 2021-10-01 at 15 56 28 Screen Shot 2021-10-01 at 15 58 34
gray.4 gray.5

@simurai simurai requested a review from auareyou October 1, 2021 07:04
@simurai simurai requested a review from a team as a code owner October 1, 2021 07:05
@simurai simurai requested review from vdepizzol and removed request for a team October 1, 2021 07:05
@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2021

🦋 Changeset detected

Latest commit: c5af6e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/6P5Yuw3qnfpngbDs4Cm6PMySecr3
✅ Preview: https://primitives-git-fg-disabled-primer.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

Variables changed
--- base/dist/scss/colors/_dark.scss	2021-10-01 07:06:26.807205089 +0000
+++ dist/scss/colors/_dark.scss	2021-10-01 07:06:14.406588529 +0000
@@ -333,2 +333,3 @@
     --color-sponsors-subtle: rgba(219,97,162,0.15);
+    --color-primer-fg-disabled: #484f58;
     --color-primer-canvas-backdrop: rgba(1,4,9,0.8);
--- base/dist/scss/colors/_dark_dimmed.scss	2021-10-01 07:06:26.815205395 +0000
+++ dist/scss/colors/_dark_dimmed.scss	2021-10-01 07:06:14.414588632 +0000
@@ -333,2 +333,3 @@
     --color-sponsors-subtle: rgba(201,97,152,0.15);
+    --color-primer-fg-disabled: #545d68;
     --color-primer-canvas-backdrop: rgba(28,33,40,0.8);
--- base/dist/scss/colors/_dark_high_contrast.scss	2021-10-01 07:06:26.823205701 +0000
+++ dist/scss/colors/_dark_high_contrast.scss	2021-10-01 07:06:14.422588735 +0000
@@ -333,2 +333,3 @@
     --color-sponsors-subtle: rgba(239,110,177,0.15);
+    --color-primer-fg-disabled: #7a828e;
     --color-primer-canvas-backdrop: rgba(1,4,9,0.8);
--- base/dist/scss/colors/_dark_protanopia.scss	2021-10-01 07:06:26.831206007 +0000
+++ dist/scss/colors/_dark_protanopia.scss	2021-10-01 07:06:14.430588838 +0000
@@ -333,2 +333,3 @@
     --color-sponsors-subtle: rgba(219,97,162,0.15);
+    --color-primer-fg-disabled: #484f58;
     --color-primer-canvas-backdrop: rgba(1,4,9,0.8);
--- base/dist/scss/colors/_light.scss	2021-10-01 07:06:26.787204324 +0000
+++ dist/scss/colors/_light.scss	2021-10-01 07:06:14.378588168 +0000
@@ -333,2 +333,3 @@
     --color-sponsors-subtle: #ffeff7;
+    --color-primer-fg-disabled: #8c959f;
     --color-primer-canvas-backdrop: rgba(27,31,36,0.5);
--- base/dist/scss/colors/_light_protanopia.scss	2021-10-01 07:06:26.799204783 +0000
+++ dist/scss/colors/_light_protanopia.scss	2021-10-01 07:06:14.390588322 +0000
@@ -333,2 +333,3 @@
     --color-sponsors-subtle: #ffeff7;
+    --color-primer-fg-disabled: #8c959f;
     --color-primer-canvas-backdrop: rgba(27,31,36,0.5);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants