Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease contrast for disabled text #1677

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Decrease contrast for disabled text #1677

merged 5 commits into from
Oct 20, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 12, 2021 •
edited
Loading

This updates primer/primitives to ^5.1.0 and starts to use the new --color-primer-fg-disabled. It will make disabled text have lower contrast and should make it more clear that something is disabled.

Before After
Screen Shot 2021-10-12 at 16 53 39 Screen Shot 2021-10-12 at 16 59 03
Screen Shot 2021-10-13 at 11 32 13 Screen Shot 2021-10-13 at 11 32 30
Screen Shot 2021-10-13 at 11 44 20 Screen Shot 2021-10-13 at 11 44 29
  • .btn (default) + Octicon
  • .btn-link
  • .btn-invisible
  • .btn-octicon
  • .form-control + .form-select
  • .pagination
  • .SelectMenu-item

Maybe more?

Part of https://github.com/github/primer/issues/292

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 31f072e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simurai simurai changed the title Update disabled text Decrease contrast for disabled text Oct 13, 2021
@simurai simurai marked this pull request as ready for review October 13, 2021 02:48
@simurai simurai requested a review from a team as a code owner October 13, 2021 02:48
jonrohan
jonrohan approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. It's a start until we discover more places that need the disabled variables

@pksjce pksjce mentioned this pull request Oct 13, 2021
Merged
@simurai simurai enabled auto-merge (squash) October 20, 2021 10:33
@simurai simurai merged commit cdb0faa into main Oct 20, 2021
@simurai simurai deleted the disabled-text branch October 20, 2021 10:34
@primer-css primer-css mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simurai @jonrohan @langermank