Change disabled color from muted to custom primer disabled color

[pksjce]

Summary 👻

Update primer/primitives to 5.1.0.
Start using colors.primer.fg.disabled instead of colors.fg.muted.
Context in https://github.com/github/primer/issues/292
Similar change in primer/css in primer/css#1677

Before n After ✨

Component	Before	After
TextInput
Default Button
Invisible Button
Action list item

[changeset-bot]

🦋 Changeset detected

Latest commit: 53fdc9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	53.9 KB (+0.01% 🔺)
dist/browser.umd.js	54.28 KB (+0.02% 🔺)

[colebemis]

@pksjce These CI are caused by breaking changes in Primer Primitives v5. I'm going to open a separate PR to fix these errors.

[colebemis]

Here's a draft of the PR to update primitives: #1514

[simurai]

Should we include these two components as well:

• Disabled item for the Pagination:

  react/src/Pagination/Pagination.tsx

  Line 58 in c156b07

  color: ${get('colors.fg.muted')}; // check

• Disabled TextInput:

  react/src/_TextInputWrapper.tsx

  Line 82 in c156b07

  color: ${get('colors.fg.muted')};

  We probably would need to add it to the ::placeholder as well? Here the change in Primer CSS

[pksjce]

@simurai - Updated the color on a bunch of more places!

[simurai]

Updated the color on a bunch of more places!

Ohh.. that might be a few too many. The colors.primer.fg.disabled isn't meant for replacing all of colors.fg.muted and only in situations when a component has a disabled state. For example when adding the disabled attribute to a <button>.

When using colors.primer.fg.disabled for the "normal" state, for example on the BranchName component, then the text might be too subtle and hard to read:

Before	After
colors.fg.muted	colors.primer.fg.disabled

So I think we should revert 57b66e3 again and only additionally replace it for disabled Pagination and TextInput: #1512 (review)

[pksjce]

Thanks @simurai for that review! I have made the appropriate changes.

[simurai]

👍 Ok, this looks good to me.

[colebemis]

🚢