Release Tracking

[github-actions]

tl;dr status:

• All CI failures are accounted for. Some required reverts, some are fixed in gh/gh
• ✅ 36.13.0 published
• upgrade PR for gh/gh: https://github.com/github/github/pull/320337
• 1 fix in gh/gh waiting for review: https://github.com/github/github/pull/320152
• ✅ Need to copy this commit to the upgrade PR (not possible to merge without upgrade PR): https://github.com/github/github/pull/317915/commits/e684823ec59d3991cecae9447a472ce749f85add

---

Reverts and fixes

Reverts:

1. Revert "Adds aria-expanded="false" back to AnchoredOverlay" #4455
2. Revert "Add loading prop for Button and IconButton (#3582)" #4464
3. Revert "Add support for nested submenus to ActionMenu" #4472

Fixes:

1. RelativeTime: prefer children if passed (fix #4305) #4465
2. https://github.com/github/github/pull/320152
3. https://github.com/github/github/pull/319551
4. https://github.com/github/github/pull/319732
5. Updated outdated test after RelativeTime SSR github/github@e684823

---

This is a scheduled issue for tracking the release between Monday, March 25th and Monday, April 8th

Last week	Value
Issue	Release Tracking
Conductor	@siddharthkp
Release Pull Request	Link
Integration tests	Link

Timeline

Monday, March 25th

• Hello! Checking in, seems like the integration tests are broken, so there's where I'll start. The commit history has some hints, if not enough.

Wednesday, March 27th

• Narrowing down when it started breaking exactly to get to the problematic PR:

  🔴 36.13.0-rc.415c1e88f github-js-jest, github-licenses (PR with fix)
  🔴 36.12.1-rc.ee9ae46cd github-licenses failing

Thursday, March 28th

• Narrowed down one of the failures to matchMedia mock

Tuesday, April 2nd

• https://github.com/github/github/pull/319551, going to merge into integration PR. One error less now.
• 36.13.0-rc.34a76fa7d new errors in github-js-jest, github-axe-scan, github-lint-js
  • Have to revert one PR, can't fix it in the integration PR because it needs changes to how the component is used :( Revert "Adds aria-expanded="false" back to AnchoredOverlay" #4455

Wednesday, April 3rd

• https://github.com/github/github/pull/319555, added lit-labs/ssr-dom-shim to esmDependencies for jest, https://github.com/github/github/pull/319732
• The workflow could not publish a new release candidate after reverting AnchoredOverlay 😠
• ActionMenu.Button seems to now have aria-labelledby always, even if it has aria-label which is incorrect, comes from https://github.com/primer/react/pull/3582/files#diff-515525e4a59d9a55e13c6c60155ec6782c78a026aae4c540c324cd8e11c83a48R38
  • PR cannot be reverted because content has changed 😟
  • Decided to fix it instead: Button: only add fallback aria-labelledby if aria-label isn't present #4459

Thursday, April 4th

• There are other instances of CI failures as well, need to revert Add loading prop for Button and IconButton #3582 instead: Revert "Add loading prop for Button and IconButton (#3582)" #4464
• Next issue is in automatically provide localised Date for SSR in RelativeTime #4305, fixed in RelativeTime: prefer children if passed (fix #4305) #4465
• Next issue is in fix(octicons_react): remove role if aria-hidden octicons#1007, turns out there are tests that do a getByRole(img) which surprisingly works even when the image is hidden. Updated tests locally, will pull out into a PR

Friday, April 5th

• Pulled out changes related to octicon: https://github.com/github/github/pull/320152
• Only 2 jest test failures left 🎉
• Down to just 1 error, related to nestable ActionMenu
• Found a bug, need to revert: Revert "Add support for nested submenus to ActionMenu" #4472

Weekend summary:

• Waiting for review on 2 PRs and then we should be good to ship! Revert "Add support for nested submenus to ActionMenu" #4472 and Revert "Add support for nested submenus to ActionMenu" #4472
• Need to copy this commit to the upgrade PR (can't merge it before): https://github.com/github/github/pull/317915/commits/e684823ec59d3991cecae9447a472ce749f85add

Checklist

• Checks have passed on the integration Pull Request downstream
• Release tracking Pull Request has been merged
• Stable release available on npm
• Downstream repos have been updated to latest

Notes