Revert "Add loading prop for Button and IconButton (#3582)"

[siddharthkp]

• This reverts Add loading prop for Button and IconButton #3582 by reverting commit 3be64c5
• Reopen https://github.com/github/primer/issues/2680

Sorry @langermank! Found some more bugs in integration tests that I wasn't able to fix inline

Bugs spotted in CI failures:

1. In Add loading prop for Button and IconButton #3582, we introduced an aria-labelledby for all instances of Button. This however isn't a good idea when aria-label is already present on the instance because aria-labelledby takes precedence over aria-label (we only want to add a fallback aria-labelledby when aria-label isn't present) (see CI error)
2. Text in trailingVisual (counter, keyboard shortcuts hint, etc) was included in the label, this was removed in Add loading prop for Button and IconButton #3582 example: github/github/CommandButton (see CI error)

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; Reverts unreleased PR

Next steps:

1. After this PR is merged, please revert this pull request to bring back your changes in a new PR.
2. Mark as ready to review once you have tested with dotcom

Follow this guide to run integration tests for your pull request in dotcom: https://github.com/github/primer-engineering/blob/main/how-we-work/testing-primer-react-pr-at-dotcom.md

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6d30160

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	87.92 KB (-1.2% 🔽)
packages/react/dist/browser.umd.js	88.29 KB (-1.08% 🔽)

[maximedegreve]

Approved since it's a revert