Button bug fixes and visual updates #2374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79f8967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
langermank
changed the title
langermank
commented
Oct 7, 2022
langermank
commented
Oct 7, 2022
| /** | ||
| * The trailing icon comes after button content | ||
| */ | ||
| trailingIcon?: React.FunctionComponent<React.PropsWithChildren<IconProps>> | ||
| trailingVisual?: React.FunctionComponent<React.PropsWithChildren<IconProps>> |
There was a problem hiding this comment.
Same question - should we add a unit test for it?
6 tasks
|
Closing in favor of #2714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: These are breaking changes and should be considered for the next major release
Improvements
blockprop for full widthalignContentprop to align content to center or startcontrolsizing CSS variablesheightover padding for more control over sizingButton.Counterto better align with the other visual propsVisual updates
Addresses a few things missing from this discussion: https://github.com/github/primer/discussions/1016
outlinevariantinvisiblehover states (will update these colors when new functional colors are addressed)Closes:
Screenshots
Please refer to the comprehensive Storybook stories- this is just a small sample of some of the changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.