Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button bug fixes and visual updates #2374

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/mean-parrots-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
"@primer/react": major
---


- Add a block prop for full width
- Add alignContent prop to align content to center or start
- Use control sizing CSS variables
- Use height over padding for more control over sizing
- Refactor Button.Counter to better align with the other visual props
- Rename visual props to better align with other Primer components
- Deprecate outline variant

1 change: 1 addition & 0 deletions .storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module.exports = {
'@storybook/addon-a11y',
'@storybook/addon-links',
'@storybook/addon-interactions',
'@storybook/addon-storysource',
{name: '@storybook/addon-essentials', options: {backgrounds: false}},
'storybook-addon-performance/register',
{name: 'storybook-addon-turbo-build', options: {optimizationLevel: 2}},
Expand Down
1 change: 0 additions & 1 deletion .storybook/preview.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {addons} from '@storybook/addons'
import {withPerformance} from 'storybook-addon-performance'
import {withThemeProvider, toolbarTypes} from '../src/utils/story-helpers'

export const globalTypes = toolbarTypes
export const decorators = [withThemeProvider, withPerformance]

Expand Down
Loading