-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for controlling which side ActionMenu
renders on (via a side
prop on ActionMenu.Overlay
)
#3714
Conversation
🦋 Changeset detectedLatest commit: 23f7889 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Perfect use case for the prop.
Not blocking: Can we also add a story with nested menus to keep in examples of the ideal use case?
Unfortunately the nested menu case requires a bit more wiring up than that because of keyboard navigation & roles. We are internally working on a |
Adds a
side
prop toActionMenu.Overlay
so the consumer can control which side of the anchor theActionMenu
renders on. This prop is forwarded verbatim to ` Also adds a story and updates docs.Closes #3712
Screenshots
Merge checklist
[ ] Added/updated testsActionMenu.tsx
#3713