Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #3717

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Release tracking #3717

merged 1 commit into from
Sep 20, 2023

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Sep 7, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@35.30.0

Minor Changes

  • #3714 88340269 Thanks @iansan5653! - Add support for controlling which side ActionMenu renders on (via a side prop on ActionMenu.Overlay)

  • #3715 1f889281 Thanks @joshblack! - Add support for leadingVisual and trailingVisual props to Button

  • #3739 b90e5476 Thanks @joshblack! - Add the Column type and createColumnHelper function to easily define columns for DataTable

  • #3719 500e529d Thanks @joshblack! - The UnderlineNav, FilterList, and FilteredSearch components will be deprecated in v36 and have been moved to the deprecated entrypoint. To use the new UnderlineNav, migrate to the component available in drafts.

  • #3732 8928acc3 Thanks @joshblack! - Add default type="button" to IconButton component

Patch Changes

@primer primer bot requested review from a team and broccolinisoup September 7, 2023 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 100.74 KB (0%)
dist/browser.umd.js 101.32 KB (0%)

@primer primer bot temporarily deployed to github-pages September 7, 2023 15:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 7, 2023 15:45 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 47875cd to 6e3e981 Compare September 7, 2023 16:25
@primer primer bot temporarily deployed to github-pages September 7, 2023 16:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 7, 2023 16:32 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 6e3e981 to 2d68b60 Compare September 7, 2023 20:39
@primer primer bot temporarily deployed to github-pages September 7, 2023 20:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 7, 2023 20:46 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 2d68b60 to 9706701 Compare September 7, 2023 21:00
@primer primer bot temporarily deployed to github-pages September 7, 2023 21:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 7, 2023 21:09 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 9706701 to b98c276 Compare September 7, 2023 21:14
@primer primer bot temporarily deployed to github-pages September 7, 2023 21:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 7, 2023 21:20 Inactive
@primer primer bot force-pushed the changeset-release/main branch from b98c276 to cbe30e7 Compare September 8, 2023 17:09
@primer primer bot temporarily deployed to github-pages September 8, 2023 17:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 8, 2023 17:17 Inactive
@primer primer bot force-pushed the changeset-release/main branch from cbe30e7 to f55965c Compare September 11, 2023 13:33
@primer primer bot temporarily deployed to github-pages September 11, 2023 13:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 11, 2023 13:40 Inactive
@primer primer bot force-pushed the changeset-release/main branch 3 times, most recently from 6f90dbc to a6541bc Compare September 11, 2023 15:16
@primer primer bot temporarily deployed to github-pages September 13, 2023 23:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 13, 2023 23:35 Inactive
@siddharthkp siddharthkp mentioned this pull request Sep 14, 2023
4 tasks
@primer primer bot force-pushed the changeset-release/main branch from 2ce229c to ba766a4 Compare September 15, 2023 05:12
@primer primer bot temporarily deployed to github-pages September 15, 2023 05:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 15, 2023 05:22 Inactive
@primer primer bot force-pushed the changeset-release/main branch from ba766a4 to ffbc3a7 Compare September 15, 2023 15:59
@primer primer bot temporarily deployed to github-pages September 15, 2023 16:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 15, 2023 16:06 Inactive
@primer primer bot force-pushed the changeset-release/main branch 4 times, most recently from bca4dfe to 4123fac Compare September 18, 2023 15:09
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 18, 2023 15:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 18, 2023 15:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 18, 2023 15:16 Inactive
@primer primer bot temporarily deployed to github-pages September 18, 2023 15:16 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 18, 2023 15:16 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 4123fac to ed43f81 Compare September 18, 2023 17:00
@primer primer bot temporarily deployed to github-pages September 18, 2023 17:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3717 September 18, 2023 17:06 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go!

See release tracking issue for more details

@siddharthkp siddharthkp added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 4bcc98e Sep 20, 2023
@siddharthkp siddharthkp deleted the changeset-release/main branch September 20, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants