Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): export components deprecated in v36 from @primer/react/deprecated #3719

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

joshblack
Copy link
Member

Part of: https://github.com/github/primer/issues/2628

Add components deprecated for v35 to deprecated entrypoint in v35 so that we can migrate teams before the v36 release.

@joshblack joshblack requested review from a team and siddharthkp September 7, 2023 17:31
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 0018024

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 100.69 KB (0%)
dist/browser.umd.js 101.27 KB (0%)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joshblack joshblack added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 500e529 Sep 8, 2023
@joshblack joshblack deleted the feat/add-deprecated-components-for-v36 branch September 8, 2023 17:08
This was referenced Sep 8, 2023
@siddharthkp siddharthkp changed the title feat(npm): move deprecated components in v36 to deprecated feat(npm): copy deprecated components in v36 to deprecated Sep 20, 2023
@siddharthkp siddharthkp changed the title feat(npm): copy deprecated components in v36 to deprecated feat(npm): export components deprecated in v36 from deprecated/index Sep 20, 2023
@siddharthkp siddharthkp changed the title feat(npm): export components deprecated in v36 from deprecated/index feat(npm): export components deprecated in v36 from @primer/react/deprecated Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants