Bug fix: ButtonGroup with Tooltips

[langermank]

Closes #4129

Related:

• https://github.com/github/primer/issues/4189
• https://github.com/github/primer/issues/4190

Changelog

Made CSS a bit more specific

New

Changed

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: d30f6fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	103.18 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js	103.6 KB (+0.08% 🔺)

[iansan5653]

I was pointed here from #5452, and just wanted to make a small suggestion: instead of wrapping each item in a container, it might be easier and safer to just switch to using first-of-type and last-of-type selectors - something like &:is(button, a):last-of-type.

[jonrohan]

@iansan5653 I attempted to do that here #5343 and that caused these bugs I think cause it's not always all button or all a

[github-actions]

Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check #5123 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

[primer-integration]

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355518

[primer-integration]

🟢 golden-jobs completed with status success.

[jonrohan]

🥇

[jonrohan]

One alternative idea I had here was to check when the child is the last item, we could add a special classname to re-round the corners, thinking it might be more predictable than relying on direct children selectors. But this also works and I'm fine with it getting out like this.