Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Use first-of-type for buttongroup selector #5343

Merged
merged 3 commits into from
Dec 3, 2024
Merged

BugFix: Use first-of-type for buttongroup selector #5343

merged 3 commits into from
Dec 3, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 3, 2024 •
edited
Loading

While cleaning up the ButtonGroup feature flags #5339, I noticed a bug in the Overlay screenshots where the last-child button didn't have the correct border radius.

This is because of the hidden Tooltip component in the group of items. I updated the selector to use :is(button, a) and :first-of-type and :last-of-type pseudo-classes to fix the issue. The updated screenshots show the issue.

Changelog

New

Changed

Fix issue in ButtonGroup Overlay screenshots by updating the selector to use :is(button, a) and :first-of-type and :last-of-type pseudo-classes.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 426beb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5343 December 3, 2024 00:08 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.53 KB (+0.11% 🔺)
packages/react/dist/browser.umd.js 103.8 KB (+0.01% 🔺)

@primer primer bot temporarily deployed to github-pages December 3, 2024 00:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5343 December 3, 2024 00:17 Inactive
@jonrohan jonrohan marked this pull request as ready for review December 3, 2024 00:19
@jonrohan jonrohan requested review from a team as code owners December 3, 2024 00:19
@jonrohan jonrohan added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 70005b8 Dec 3, 2024
43 checks passed
@jonrohan jonrohan deleted the buttongroup_last_of_type_fix branch December 3, 2024 01:21
@primer primer bot mentioned this pull request Dec 2, 2024
Merged
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "BugFix: Use first-of-type for buttongroup selector (#5343)"
5c60d08 
This reverts commit 70005b8.
@jonrohan jonrohan mentioned this pull request Dec 10, 2024
Closed
13 tasks
jonrohan added a commit that referenced this pull request Dec 10, 2024
@jonrohan
Revert "BugFix: Use first-of-type for buttongroup selector (#5343)"
3be386c 
This reverts commit 70005b8.
@jonrohan jonrohan mentioned this pull request Dec 11, 2024
Merged
13 tasks
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@jonrohan
Revert ButtonGroup changes from last release 37.7.0 (#5412)
d9e62e9 
* Revert "chore(ButtonGroup): Remove the CSS modules feature flag from ButtonGroup (#5339)"

This reverts commit dc2f083.

* Revert "BugFix: Use first-of-type for buttongroup selector (#5343)"

This reverts commit 70005b8.

* Add changeset

* @primer/react v37.7.1
@jonrohan jonrohan mentioned this pull request Dec 17, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @langermank