Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates label and legend styles for Checkbox, Radio, CheckboxGroup, and RadioGroup #5333

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

mperrotti
Copy link
Contributor

Closes #5311

Screenshots

Before

Screenshot 2024-11-25 at 5 02 11 PM

After

Screenshot 2024-11-25 at 5 01 45 PM

Changelog

New

Changed

  • Makes {Checkbox|Radio}Group <legend> bold and default font size
  • Makes Checkbox and Radio <label> default font weight

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner November 25, 2024 22:07
@mperrotti mperrotti requested a review from langermank November 25, 2024 22:07
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 2a87961

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 25, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5333 November 25, 2024 22:09 Inactive
Copy link
Contributor

github-actions bot commented Nov 25, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.68 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js 103.09 KB (+0.07% 🔺)

@primer primer bot requested a review from a team as a code owner November 25, 2024 22:32
@primer primer bot temporarily deployed to github-pages November 25, 2024 22:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5333 November 25, 2024 22:34 Inactive
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise, just a few questions.
Also since this has the potential to touch a lot of areas indirectly, I'd recommend running the integration tests and doing some manual testing in RL to make sure everything still looks good

@@ -172,17 +172,15 @@ const FormControl = React.forwardRef<HTMLDivElement, FormControlProps>(
{slots.leadingVisual}
</Box>
)}
{!slots.label?.props.visuallyHidden || slots.caption ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we don't need this check anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out why needed this check, and removing it doesn't break any VRTs or unit tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some local testing and couldn't force a difference either. Went down a bit of a rabbit hole and saw you authored this change so I'll trust you, approving! Let me know if you want help running integration checks or testing in RL

@@ -54,7 +54,6 @@ const InputLabel: React.FC<React.PropsWithChildren<Props>> = ({
display: 'block',
color: disabled ? 'fg.muted' : 'fg.default',
cursor: disabled ? 'not-allowed' : 'pointer',
alignSelf: 'flex-start',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure this is an intended change? as it doesn't seem directly correlated with Checkbox

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I mis-read alignSelf as alignItems and thought this rule wouldn't have any effect.

I'm not certain what it does, but I'll add it back just in case it's needed for something 😅

@mperrotti mperrotti added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit f0603fd Nov 26, 2024
43 checks passed
@mperrotti mperrotti deleted the mp/update-checkbox+radio-group-label-styles branch November 26, 2024 17:46
@primer primer bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckboxGroup and RadioGroup don't pair well with FormControl due to missing size variants
2 participants