-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates label and legend styles for Checkbox, Radio, CheckboxGroup, and RadioGroup #5333
Changes from 4 commits
a987a41
760cb85
7d4bfe5
9fe8082
902dd07
2a87961
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@primer/react": patch | ||
--- | ||
|
||
- Makes {Checkbox|Radio}Group `<legend>` bold and default font size | ||
- Makes Checkbox and Radio `<label>` default font weight |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,6 @@ const InputLabel: React.FC<React.PropsWithChildren<Props>> = ({ | |
display: 'block', | ||
color: disabled ? 'fg.muted' : 'fg.default', | ||
cursor: disabled ? 'not-allowed' : 'pointer', | ||
alignSelf: 'flex-start', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just making sure this is an intended change? as it doesn't seem directly correlated with Checkbox There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahh I mis-read I'm not certain what it does, but I'll add it back just in case it's needed for something 😅 |
||
...sx, | ||
}} | ||
{...props} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason we don't need this check anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't figure out why needed this check, and removing it doesn't break any VRTs or unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some local testing and couldn't force a difference either. Went down a bit of a rabbit hole and saw you authored this change so I'll trust you, approving! Let me know if you want help running integration checks or testing in RL