-
Notifications
You must be signed in to change notification settings - Fork 645
v38: Move Banner to main export #6720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8f988df The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves the Banner component from the experimental package to the main export, making it part of the stable public API. This change promotes the component's readiness status while maintaining backward compatibility and updating all related documentation and test references.
- Move Banner component exports from experimental to main package
- Update Storybook story titles from "Experimental/Components/Banner" to "Components/Banner"
- Update documentation and test references to reflect the new import path
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/index.ts | Adds Banner exports to main package and removes PointerBox exports |
| packages/react/src/experimental/index.ts | Removes Banner exports from experimental package |
| packages/react/src/Banner/Banner.stories.tsx | Updates story title from experimental to main components section |
| packages/react/src/Banner/Banner.features.stories.tsx | Updates story title from experimental to main components section |
| packages/react/src/Banner/Banner.examples.stories.tsx | Updates story title from experimental to main components section |
| packages/react/src/Banner/Banner.docs.json | Updates import path and story IDs for documentation |
| e2e/components/Banner.test.ts | Updates test story IDs to match new component location |
| NavListDividerProps, | ||
| } from './NavList' | ||
| export {default as Overlay} from './Overlay' | ||
| export type {OverlayProps} from './Overlay' |
Copilot
AI
Sep 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of PointerBox exports appears to be unrelated to the Banner migration and may be an accidental change that could break existing imports.
See below for a potential fix:
export type {OverlayProps} from './Overlay'
export {default as PointerBox} from './PointerBox'
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
The new scale is still a proposal, so we're using alpha/beta/stable for now. Buuuut, if you want here are the 17 items in the current criteria today, each criterion is worth 1 point. |
Closes https://github.com/github/primer/issues/5628
In this PR, we will move
Bannercomponent to the main export. I think it is well suited to recommend for migration fromFlashcomponent.Any advise on how to measure it in terms of our new readyness scale? @adierkens @siddharthkp ?
As a companion to this I will create a path-to-green commit on
github-uiwhere I will move all the imports from experimental to the main one.