Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Sep 5, 2025

Revert breaking changes introduced in #6676 until we can migrate the sx usage with ProgressBar in github-ui to @primer/styled-react. This unblocks integration tests for primer/react changes against github/github-ui

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why—No changeset needed, as this PR only reverts changes on main that have not yet been released

Testing & Reviewing

Merge checklist

@llastflowers llastflowers self-assigned this Sep 5, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

⚠️ No Changeset found

Latest commit: 407f5a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 5, 2025
@github-actions

This comment was marked as outdated.

@llastflowers llastflowers added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.94 KB (0%)
packages/react/dist/browser.umd.js 88.16 KB (0%)

@llastflowers llastflowers removed the integration-tests: skipped manually Changes in this PR do not require an integration test label Sep 5, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6736 September 5, 2025 18:17 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 5, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6736 September 5, 2025 18:36 Inactive
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/1907

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 5, 2025
@llastflowers llastflowers marked this pull request as ready for review September 5, 2025 20:08
Copilot AI review requested due to automatic review settings September 5, 2025 20:08
@llastflowers llastflowers requested a review from a team as a code owner September 5, 2025 20:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts breaking changes to ProgressBar.tsx by re-adding sx prop support that was previously removed. The purpose is to unblock integration tests with github-ui while maintaining backward compatibility until a proper migration can be completed.

  • Restores SxProp type import and usage
  • Adds sx prop support back to StyledProgressContainerProps and ProgressBarItems types

@llastflowers llastflowers added this pull request to the merge queue Sep 5, 2025
@llastflowers llastflowers removed this pull request from the merge queue due to a manual request Sep 5, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@llastflowers llastflowers added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 17bd85a Sep 5, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/revert-ProgressBar-styled-components-changes branch September 5, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants