- 
                Notifications
    You must be signed in to change notification settings 
- Fork 640
add sx support back to ProgressBar.tsx #6736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sx support back to ProgressBar.tsx #6736
Conversation
| 
 | 
| Name | Type | 
|---|---|
| @primer/react | Major | 
| @primer/styled-react | Major | 
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
      
        
              This comment was marked as outdated.
        
        
      
    
  This comment was marked as outdated.
| size-limit report 📦
 | 
| 👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/1907 | 
| 🟢 ci completed with status  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts breaking changes to ProgressBar.tsx by re-adding sx prop support that was previously removed. The purpose is to unblock integration tests with github-ui while maintaining backward compatibility until a proper migration can be completed.
- Restores SxProptype import and usage
- Adds sxprop support back toStyledProgressContainerPropsandProgressBarItemstypes
| 👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! | 
Revert breaking changes introduced in #6676 until we can migrate the
sxusage withProgressBarin github-ui to@primer/styled-react. This unblocks integration tests for primer/react changes against github/github-uiChangelog
New
Changed
Removed
Rollout strategy
mainthat have not yet been releasedTesting & Reviewing
Merge checklist