Skip to content

add sx support back to ProgressBar.tsx #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

add sx support back to ProgressBar.tsx #6736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16fdfd1
add sx support back to ProgressBar.tsx
llastflowers Sep 5, 2025
125d9bf
Merge branch 'main' into llastflowers/revert-ProgressBar-styled-compo…
llastflowers Sep 5, 2025
407f5a7
update changeset to reflect reverted changes
llastflowers Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .changeset/pretty-women-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
'@primer/react': major
---

Removes styled-system and related utilities from Caret.tsx, IssueLabelToken.tsx, ProgressBar.tsx, StateLabel.tsx, ToggleSwitch.tsx, and deprecated/ActionList/List.tsx
Removes styled-system and related utilities from Caret.tsx, IssueLabelToken.tsx, StateLabel.tsx, ToggleSwitch.tsx, and deprecated/ActionList/List.tsx

Removes WidthProps from ProgressBar.tsx
6 changes: 4 additions & 2 deletions packages/react/src/ProgressBar/ProgressBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, {forwardRef} from 'react'
import type {SxProp} from '../sx'
import {clsx} from 'clsx'
import classes from './ProgressBar.module.css'
import {BoxWithFallback} from '../internal/components/BoxWithFallback'
Expand All @@ -13,12 +14,13 @@ type StyledProgressContainerProps = {
inline?: boolean
barSize?: 'small' | 'default' | 'large'
animated?: boolean
}
} & SxProp

export type ProgressBarItems = React.HTMLAttributes<HTMLSpanElement> & {
'aria-label'?: string
className?: string
} & ProgressProp
} & ProgressProp &
SxProp

export const Item = forwardRef<HTMLSpanElement, ProgressBarItems>(
(
Expand Down
Loading