Skip to content

Conversation

@joshblack
Copy link
Member

Closes #6777
Part of: https://github.com/github/primer/issues/5421 (for removal of styled)

Changelog

New

Changed

  • Update styled usage to CSS Modules

Removed

  • Remove support for sx from deprecated component

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

This component has no sx usage downstream and can safely be migrated

@joshblack joshblack requested a review from a team as a code owner September 11, 2025 17:00
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: cd06b2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for the sx prop and migrates from styled-components to CSS Modules for the deprecated FilteredSearch component, as part of the broader effort to remove styled-components from the codebase.

  • Converts FilteredSearch from a styled-component to a regular React function component
  • Migrates styles from styled-components to CSS Modules using CSS custom properties
  • Removes the sx prop support which was provided by the styled-components implementation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/deprecated/FilteredSearch/FilteredSearch.tsx Converts from styled-component to function component, removes sx prop support
packages/react/src/deprecated/FilteredSearch/FilteredSearch.module.css New CSS Module containing migrated styles with CSS custom properties
.changeset/rotten-carpets-raise.md Documents the breaking change for major version release

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.64 KB (0%)
packages/react/dist/browser.umd.js 88.73 KB (0%)

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2663

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 16, 2025
@francinelucca francinelucca added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit aba8050 Sep 22, 2025
43 checks passed
@francinelucca francinelucca deleted the refactor/update-filtered-search-to-css-modules branch September 22, 2025 19:18
@primer primer bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for sx from the FilteredSearch component in @primer/react/deprecated

4 participants