-
Notifications
You must be signed in to change notification settings - Fork 639
feat(FilteredSearch): remove support for sx and styled #6840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FilteredSearch): remove support for sx and styled #6840
Conversation
🦋 Changeset detectedLatest commit: cd06b2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes support for the sx prop and migrates from styled-components to CSS Modules for the deprecated FilteredSearch component, as part of the broader effort to remove styled-components from the codebase.
- Converts FilteredSearch from a styled-component to a regular React function component
- Migrates styles from styled-components to CSS Modules using CSS custom properties
- Removes the
sxprop support which was provided by the styled-components implementation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/deprecated/FilteredSearch/FilteredSearch.tsx | Converts from styled-component to function component, removes sx prop support |
| packages/react/src/deprecated/FilteredSearch/FilteredSearch.module.css | New CSS Module containing migrated styles with CSS custom properties |
| .changeset/rotten-carpets-raise.md | Documents the breaking change for major version release |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2663 |
|
🟢 ci completed with status |
Closes #6777
Part of: https://github.com/github/primer/issues/5421 (for removal of
styled)Changelog
New
Changed
styledusage to CSS ModulesRemoved
sxfrom deprecated componentRollout strategy
This component has no
sxusage downstream and can safely be migrated