Skip to content

feat(FilteredSearch): remove support for sx and styled #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

feat(FilteredSearch): remove support for sx and styled #6840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e71f4f
feat(FilteredSearch): remove support for sx and styled
joshblack Sep 11, 2025
cd06b2a
chore: fix stylelint error
joshblack Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-carpets-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Remove support for `sx` prop from `deprecated/FilteredSearch`
19 changes: 19 additions & 0 deletions packages/react/src/deprecated/FilteredSearch/FilteredSearch.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
.FilteredSearch {
display: flex;
align-items: stretch;

& summary,
& > button {
border-radius: 0;
border-top-left-radius: var(--borderRadius-medium);
border-bottom-left-radius: var(--borderRadius-medium);
border-right: 0;
}

/* stylelint-disable-next-line selector-class-pattern */
& :global(.TextInput-wrapper) {
border-radius: 0;
border-top-right-radius: var(--borderRadius-medium);
border-bottom-right-radius: var(--borderRadius-medium);
}
}
37 changes: 12 additions & 25 deletions packages/react/src/deprecated/FilteredSearch/FilteredSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,19 @@
import styled from 'styled-components'
import {get} from '../../constants'
import type {SxProp} from '../../sx'
import sx from '../../sx'
import type {ComponentProps} from '../../utils/types'
import {clsx} from 'clsx'
import classes from './FilteredSearch.module.css'

type FilteredSearchProps = React.HTMLAttributes<HTMLElement>

/**
* @deprecated A new filter component is in progress.
* Until the new filter component is ready, you can use Button + TextInput + ActionList to reproduce this pattern.
*/
const FilteredSearch = styled.div<SxProp>`
display: flex;
align-items: stretch;

summary,
> button {
border-radius: 0;
border-top-left-radius: ${get('radii.2')};
border-bottom-left-radius: ${get('radii.2')};
border-right: 0;
}
.TextInput-wrapper {
border-radius: 0;
border-top-right-radius: ${get('radii.2')};
border-bottom-right-radius: ${get('radii.2')};
}

${sx}
`
function FilteredSearch({children, className, ...rest}: FilteredSearchProps) {
return (
<div {...rest} className={clsx(classes.FilteredSearch, className)}>
{children}
</div>
)
}

export type FilteredSearchProps = ComponentProps<typeof FilteredSearch>
export type {FilteredSearchProps}
export default FilteredSearch
Loading