-
Notifications
You must be signed in to change notification settings - Fork 645
Update release workflow to use upload-versions from the primer/.github repository #7156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the release workflow from using a local GitHub Action (.github/actions/upload-versions) to using centralized shared actions from the primer/.github repository. It also adds filtering to prevent the workflow from running on merge queue branches and tags.
- Replaces local
upload-versionsaction with shared actions fromprimer/.github@v2.4.0 - Adds new
report-versionsstep to replace custom GitHub Script implementations for reporting package versions - Adds workflow trigger filters to ignore merge queue branches and tags
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Updated to use shared actions from primer/.github@v2.4.0 for version reporting and uploading; added branch/tag filtering to workflow triggers; removed custom GitHub Script steps |
.github/actions/upload-versions/action.yml |
Deleted local action as it's replaced by the centralized shared action |
Overview
This PR refactors the release workflow to use centralized GitHub Actions from the
primer/.githubrepository instead of maintaining local copies. This change improves maintainability and ensures consistency across Primer repositories.Key Changes:
.github/actions/upload-versionsaction withprimer/.github/.github/actions/upload-versions@v2.4.0primer/.github/.github/actions/report-versions@v2.4.0to replace inline GitHub script for outputting version informationrelease-mainjob to be skippedChangelog
New
primer/.github/.github/actions/report-versions@v2.4.0action to the release-candidate and release-canary jobsgh-readonly-queue/**) and all tagsChanged
primer/.github/.github/actions/upload-versions@v2.4.0instead of local actiongithub-scriptactions for outputting version information with the centralizedreport-versionsactionRemoved
.github/actions/upload-versions/action.ymlfile (41 lines)Rollout strategy
Reason: This is a CI/CD infrastructure change that does not affect the published package or its API. It only affects internal release workflow processes.
Testing & Reviewing
Testing:
mainbranchrelease-mainjob should now run on main branch pushes (previously was being skipped due to tag triggers)report-versionsactionupload-versionsactionKey Points to Review:
primer/.github@v2.4.0provide equivalent functionality to the removed local action and inline scriptsMerge checklist
Note: Most merge checklist items are not applicable for this CI/CD infrastructure change. The changes are SSR compatible as they don't affect runtime code.