Remove hx_Subhead--responsive (#870)

primer · Nov 11, 2021 · 670a44c · 670a44c · vercel · Nov 11, 2021
1 parent 2f8605c
commit 670a44c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/app/components/primer/subhead_component.rb b/app/components/primer/subhead_component.rb
@@ -117,7 +117,7 @@ def initialize(spacious: false, hide_border: false, **system_arguments)
       @system_arguments[:classes] =
         class_names(
           @system_arguments[:classes],
-          "Subhead hx_Subhead--responsive",
+          "Subhead",
           "Subhead--spacious": spacious,
           "border-bottom-0": hide_border
         )

diff --git a/docs/content/components/subhead.md b/docs/content/components/subhead.md
@@ -61,7 +61,7 @@ The description
 
 ### Default
 
-<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'>  <h3 data-view-component='true' class='Subhead-heading'>    My Heading</h3>    <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
+<Example src="<div data-view-component='true' class='Subhead'>  <h3 data-view-component='true' class='Subhead-heading'>    My Heading</h3>    <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
 
 ```erb
 <%= render(Primer::SubheadComponent.new) do |component| %>
@@ -76,7 +76,7 @@ The description
 
 ### With dangerous heading
 
-<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'>  <h3 data-view-component='true' class='Subhead-heading Subhead-heading--danger'>    My Heading</h3>    <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
+<Example src="<div data-view-component='true' class='Subhead'>  <h3 data-view-component='true' class='Subhead-heading Subhead-heading--danger'>    My Heading</h3>    <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
 
 ```erb
 <%= render(Primer::SubheadComponent.new) do |component| %>
@@ -91,7 +91,7 @@ The description
 
 ### With long description
 
-<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'>  <h3 data-view-component='true' class='Subhead-heading'>    My Heading</h3>    </div><p> This is a longer description that is sitting below the Subhead. It's much longer than a description that could sit comfortably in the Subhead. </p>" />
+<Example src="<div data-view-component='true' class='Subhead'>  <h3 data-view-component='true' class='Subhead-heading'>    My Heading</h3>    </div><p> This is a longer description that is sitting below the Subhead. It's much longer than a description that could sit comfortably in the Subhead. </p>" />
 
 ```erb
 <%= render(Primer::SubheadComponent.new) do |component| %>
@@ -104,7 +104,7 @@ The description
 
 ### Without border
 
-<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive border-bottom-0 mb-0'>  <div data-view-component='true' class='Subhead-heading'>    My Heading</div>    <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
+<Example src="<div data-view-component='true' class='Subhead border-bottom-0 mb-0'>  <div data-view-component='true' class='Subhead-heading'>    My Heading</div>    <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
 
 ```erb
 <%= render(Primer::SubheadComponent.new(hide_border: true)) do |component| %>
@@ -119,7 +119,7 @@ The description
 
 ### With actions
 
-<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'>  <div data-view-component='true' class='Subhead-heading'>    My Heading</div>  <div data-view-component='true' class='Subhead-actions'>    <a href='http://www.google.com' role='button' data-view-component='true' class='btn-danger btn'>    Action  </a></div>  <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
+<Example src="<div data-view-component='true' class='Subhead'>  <div data-view-component='true' class='Subhead-heading'>    My Heading</div>  <div data-view-component='true' class='Subhead-actions'>    <a href='http://www.google.com' role='button' data-view-component='true' class='btn-danger btn'>    Action  </a></div>  <div data-view-component='true' class='Subhead-description'>    My Description</div></div>" />
 
 ```erb
 <%= render(Primer::SubheadComponent.new) do |component| %>

diff --git a/static/classes.yml b/static/classes.yml
@@ -149,7 +149,6 @@
 - ".gutter-lg"
 - ".h2"
 - ".hidden-text-expander"
-- ".hx_Subhead--responsive"
 - ".inline"
 - ".left-0"
 - ".lh-0"

diff --git a/test/lib/css_coverage_test.rb b/test/lib/css_coverage_test.rb
@@ -37,7 +37,6 @@ def setup
       ".p-lg-responsive",
       ".m-xl-auto",
       ".p-xl-responsive",
-      ".hx_Subhead--responsive",
       # used to showcase custom classes in component docs
       ".custom-class",
       "."