Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hx_Subhead--responsive #870

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Remove hx_Subhead--responsive #870

merged 2 commits into from
Nov 11, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 26, 2021

This is part of https://github.com/github/primer/issues/322 and removes the hx_Subhead--responsive class.

Subhead is now responsive by default and this class is not needed anymore.

@vercel
Copy link

vercel bot commented Oct 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/view-components/AshTgsk54d2GQGWszNjAEaBPMx5M
✅ Preview: https://view-components-git-remove-hxsubhead-responsive-primer.vercel.app

@manuelpuyol
Copy link
Contributor

@jonrohan do we have a plan to update to PrimerCSS 18? Some color variables changed and will break our utilities

@jonrohan
Copy link
Member

jonrohan commented Oct 26, 2021

@jonrohan do we have a plan to update to PrimerCSS 18? Some color variables changed and will break our utilities

I was hoping we could get the release out with 17.11.1 first so we have time to migrate. It was merged in #858

@simurai
Copy link
Contributor Author

simurai commented Nov 1, 2021

@manuelpuyol do we have a plan to update to PrimerCSS 18? Some color variables changed and will break our utilities

@jonrohan I was hoping we could get the release out with 17.11.1 first so we have time to migrate. It was merged in #858

Actually, I think we don't have to wait for PrimerCSS 18. Because the hx_Subhead--responsive styles got removed in https://github.com/github/github/pull/198706 on dotcom and they were never part of PrimerCSS. So I guess this PR could already be merged since having hx_Subhead--responsive doesn't really do anything anymore.

@simurai simurai marked this pull request as ready for review November 1, 2021 06:21
@simurai simurai requested review from a team and joelhawksley November 1, 2021 06:21
@simurai simurai enabled auto-merge (squash) November 11, 2021 03:41
@vercel vercel bot temporarily deployed to Preview November 11, 2021 03:41 Inactive
@simurai simurai merged commit 670a44c into main Nov 11, 2021
@simurai simurai deleted the remove-hx_Subhead--responsive branch November 11, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants