Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hx_Subhead--responsive #870

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Remove hx_Subhead--responsive #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993d4ed
Remove hx_Subhead--responsive
simurai Oct 26, 2021
4382182
Merge branch 'main' into remove-hx_Subhead--responsive
simurai Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/primer/subhead_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def initialize(spacious: false, hide_border: false, **system_arguments)
@system_arguments[:classes] =
class_names(
@system_arguments[:classes],
"Subhead hx_Subhead--responsive",
"Subhead",
"Subhead--spacious": spacious,
"border-bottom-0": hide_border
)
Expand Down
10 changes: 5 additions & 5 deletions docs/content/components/subhead.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ The description

### Default

<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'> <h3 data-view-component='true' class='Subhead-heading'> My Heading</h3> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />
<Example src="<div data-view-component='true' class='Subhead'> <h3 data-view-component='true' class='Subhead-heading'> My Heading</h3> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />

```erb
<%= render(Primer::SubheadComponent.new) do |component| %>
Expand All @@ -76,7 +76,7 @@ The description

### With dangerous heading

<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'> <h3 data-view-component='true' class='Subhead-heading Subhead-heading--danger'> My Heading</h3> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />
<Example src="<div data-view-component='true' class='Subhead'> <h3 data-view-component='true' class='Subhead-heading Subhead-heading--danger'> My Heading</h3> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />

```erb
<%= render(Primer::SubheadComponent.new) do |component| %>
Expand All @@ -91,7 +91,7 @@ The description

### With long description

<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'> <h3 data-view-component='true' class='Subhead-heading'> My Heading</h3> </div><p> This is a longer description that is sitting below the Subhead. It's much longer than a description that could sit comfortably in the Subhead. </p>" />
<Example src="<div data-view-component='true' class='Subhead'> <h3 data-view-component='true' class='Subhead-heading'> My Heading</h3> </div><p> This is a longer description that is sitting below the Subhead. It's much longer than a description that could sit comfortably in the Subhead. </p>" />

```erb
<%= render(Primer::SubheadComponent.new) do |component| %>
Expand All @@ -104,7 +104,7 @@ The description

### Without border

<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive border-bottom-0 mb-0'> <div data-view-component='true' class='Subhead-heading'> My Heading</div> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />
<Example src="<div data-view-component='true' class='Subhead border-bottom-0 mb-0'> <div data-view-component='true' class='Subhead-heading'> My Heading</div> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />

```erb
<%= render(Primer::SubheadComponent.new(hide_border: true)) do |component| %>
Expand All @@ -119,7 +119,7 @@ The description

### With actions

<Example src="<div data-view-component='true' class='Subhead hx_Subhead--responsive'> <div data-view-component='true' class='Subhead-heading'> My Heading</div> <div data-view-component='true' class='Subhead-actions'> <a href='http://www.google.com' role='button' data-view-component='true' class='btn-danger btn'> Action </a></div> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />
<Example src="<div data-view-component='true' class='Subhead'> <div data-view-component='true' class='Subhead-heading'> My Heading</div> <div data-view-component='true' class='Subhead-actions'> <a href='http://www.google.com' role='button' data-view-component='true' class='btn-danger btn'> Action </a></div> <div data-view-component='true' class='Subhead-description'> My Description</div></div>" />

```erb
<%= render(Primer::SubheadComponent.new) do |component| %>
Expand Down
1 change: 0 additions & 1 deletion static/classes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@
- ".gutter-lg"
- ".h2"
- ".hidden-text-expander"
- ".hx_Subhead--responsive"
- ".inline"
- ".left-0"
- ".lh-0"
Expand Down
1 change: 0 additions & 1 deletion test/lib/css_coverage_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ def setup
".p-lg-responsive",
".m-xl-auto",
".p-xl-responsive",
".hx_Subhead--responsive",
# used to showcase custom classes in component docs
".custom-class",
"."
Expand Down