Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap bg-gradient with bg-color for Banner/Flash #2643

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Feb 27, 2024

Replace background-image gradient with background-color as the gradient used a single color value.

@langermank langermank requested a review from a team as a code owner February 27, 2024 19:16
Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: f8372c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there some reason we were doing this? weird cause linear-gradient was going from the same color to the same color without really doing a gradient

@langermank langermank merged commit 70a6dee into main Feb 27, 2024
31 checks passed
@langermank langermank deleted the remove-banner-gradient branch February 27, 2024 20:43
@primer primer bot mentioned this pull request Feb 27, 2024
@primer primer bot mentioned this pull request Mar 15, 2024
langermank added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants