Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap bg-gradient with bg-color for Banner/Flash #2643

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Swap bg-gradient with bg-color for Banner/Flash #2643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7f333
swap to bg color
langermank Feb 27, 2024
f8372c4
Create yellow-rings-approve.md
langermank Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-rings-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Swap bg-gradient with bg-color for Banner/Flash
8 changes: 4 additions & 4 deletions app/components/primer/alpha/banner.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
display: grid;
padding: var(--base-size-8);
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-accent-muted), var(--bgColor-accent-muted));
background-color: var(--bgColor-accent-muted);
border: var(--borderWidth-thin) solid var(--borderColor-accent-muted);
border-radius: var(--borderRadius-medium);
grid-auto-flow: column;
Expand Down Expand Up @@ -78,7 +78,7 @@

&.Banner--warning {
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-attention-muted), var(--bgColor-attention-muted));
background-color: var(--bgColor-attention-muted);
border-color: var(--borderColor-attention-muted);

& .Banner-visual .octicon {
Expand All @@ -88,7 +88,7 @@

&.Banner--error {
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-danger-muted), var(--bgColor-danger-muted));
background-color: var(--bgColor-danger-muted);
border-color: var(--borderColor-danger-muted);

& .Banner-visual .octicon {
Expand All @@ -98,7 +98,7 @@

&.Banner--success {
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-success-muted), var(--bgColor-success-muted));
background-color: var(--bgColor-success-muted);
border-color: var(--borderColor-success-muted);

& .Banner-visual .octicon {
Expand Down
8 changes: 4 additions & 4 deletions app/components/primer/beta/flash.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

/* Default color */
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-accent-muted), var(--bgColor-accent-muted));
background-color: var(--bgColor-accent-muted);
border-color: var(--borderColor-accent-muted);

& .octicon {
Expand Down Expand Up @@ -78,7 +78,7 @@

.flash-warn:not(.Banner) {
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-attention-muted), var(--bgColor-attention-muted));
background-color: var(--bgColor-attention-muted);
border-color: var(--borderColor-attention-muted);

& .octicon {
Expand All @@ -88,7 +88,7 @@

.flash-error:not(.Banner) {
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-danger-muted), var(--bgColor-danger-muted));
background-color: var(--bgColor-danger-muted);
border-color: var(--borderColor-danger-muted);

& .octicon {
Expand All @@ -98,7 +98,7 @@

.flash-success:not(.Banner) {
color: var(--fgColor-default);
background-image: linear-gradient(var(--bgColor-success-muted), var(--bgColor-success-muted));
background-color: var(--bgColor-success-muted);
border-color: var(--borderColor-success-muted);

& .octicon {
Expand Down
Loading