-
Notifications
You must be signed in to change notification settings - Fork 855
fix: add callout to Prisma Config DC-4961 #7095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation updates: simplified the exported PrismaConfig example in the schema location guide (removed Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
Deploying docs with
|
Latest commit: |
e2ee0aa
|
Status: | ✅ Deploy successful! |
Preview URL: | https://406925ed.docs-51g.pages.dev |
Branch Preview URL: | https://ankur-patch-prisma-config.docs-51g.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/200-orm/500-reference/100-prisma-schema-reference.mdx (1)
175-176
: RemovemoduleFormat
from theprisma-client-js
field tableListing
moduleFormat
underprisma-client-js
but stating it is only available withprisma-client
is confusing. Suggest removing it from this table (it’s correctly documented under theprisma-client
section).-| `moduleFormat` | No | Enum (`cjs` or `esm`) | Defines the module format of the generated Prisma Client. This field is available only with `prisma-client` generator. |
References show
moduleFormat
applies to the previewprisma-client
generator, notprisma-client-js
. (prisma.io)
🧹 Nitpick comments (2)
content/200-orm/100-prisma-schema/10-overview/04-location.mdx (1)
72-72
: Fix small typos in this pageTwo minor text nits:
- Line 72: “pass the the
--schema
option” → “pass the--schema
option”- Line 102: “here's how how need to place” → “here’s how you need to place”
- - pass the the `--schema` option to your Prisma CLI command (e.g. `prisma migrate dev --schema ./prisma`) + - pass the `--schema` option to your Prisma CLI command (e.g. `prisma migrate dev --schema ./prisma`) - For example, assuming `schema.prisma` defines the `datasource`, here's how how need to place the migrations folder: + For example, assuming `schema.prisma` defines the `datasource`, here’s how you need to place the migrations folder:Also applies to: 102-102
content/200-orm/500-reference/100-prisma-schema-reference.mdx (1)
177-181
: Admonition style consistencyYou’re using “:::note[important]” here while other parts of the page use either plain “:::note” or the
<Admonition>
MDX component. Consider standardizing to the dominant style for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
content/200-orm/100-prisma-schema/10-overview/04-location.mdx
(1 hunks)content/200-orm/500-reference/100-prisma-schema-reference.mdx
(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ankur-arch
PR: prisma/docs#7066
File: content/200-orm/200-prisma-client/700-debugging-and-troubleshooting/245-troubleshooting-binary-size-issues.mdx:8-22
Timestamp: 2025-08-11T09:40:55.237Z
Learning: When the queryCompiler preview feature is enabled in Prisma ORM (v6.7.0+), it does not require Rust engines for CLI tools like `prisma migrate` or `prisma db pull`. The previous understanding that CLI tools would still need Rust binaries even with queryCompiler enabled is incorrect.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Check internal links
- GitHub Check: runner / linkspector
- GitHub Check: Lost Pixel
- GitHub Check: Cloudflare Pages
🔇 Additional comments (4)
content/200-orm/100-prisma-schema/10-overview/04-location.mdx (2)
87-90
: PrismaConfig sample: good updateDropping
earlyAccess
andPrismaConfig<Env>
in favor ofsatisfies PrismaConfig
matches current Prisma Config guidance.
See reference. (prisma.io)
92-97
: Helpful calloutThe new note recommending Prisma Config for schema path is clear and aligns with Config docs.
(prisma.io)content/200-orm/500-reference/100-prisma-schema-reference.mdx (2)
164-165
: Clarification about default generator (6.x and earlier): looks goodCalling out that
prisma-client-js
is the default up to 6.x helps readers during the v7 transition.
(prisma.io)
185-192
: Preview generator section: content aligns with current status—keep runtime list freshThe description of the ESM-first
prisma-client
and the note about becoming default in v7 are accurate; as of September 2, 2025 the latest release is 6.15.0 (not yet v7). Also, the runtime values you list (nodejs
,deno
,bun
,workerd
,vercel-edge
,react-native
) match the latest 6.15.0 change log updates.
- If this page ships after v7 GA, update phrasing from “will be the default” to “is the default”.
- Confirm the runtime list stays in sync with release notes.
Sources: latest releases and generator docs. (github.com, prisma.io)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
e2ee0aa
* fix: add callout to Prisma Config DC-4961 * fix: add callouts to the new prisma-client generator * fix: replace grammarbook link
Summary by CodeRabbit