Skip to content

Conversation

AmanVarshney01
Copy link
Contributor

@AmanVarshney01 AmanVarshney01 commented Oct 8, 2025

Summary by CodeRabbit

  • Documentation
    • Updated TypedSQL docs to reflect the prisma-client generator option and configurable output path.
    • Switched code samples to generated import paths, with notes on default @prisma/client imports when not customizing output.
    • Added guidance on Custom SQL folder location and configuring typedSql.path.
    • Refreshed examples/links to the TypedSQL example repo.
    • Standardized formatting and annotations across code blocks and examples.

Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Documentation updates in the TypedSQL page adjust generator configuration, note new output paths and custom folders, update import paths to use generated client/sql locations, add guidance on default vs. generated imports, and refresh code samples and example links to the TypedSQL example repository.

Changes

Cohort / File(s) Summary of Changes
Docs: TypedSQL generator and imports
content/200-orm/200-prisma-client/150-using-raw-sql/100-typedsql.mdx
- Switch generator provider snippet to prisma-client (noting prisma-client-js support) and add output path example
- Add Custom SQL folder note and prisma.config.ts snippet (typedSql.path)
- Update imports from @prisma/client and @prisma/client/sql to ./generated/prisma/client and ./generated/prisma/sql (with note about defaults)
- Align code samples (titles/formatting) and update example links to TypedSQL example repo
- Update argument-passing and typing sections to use generated paths

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • mhessdev
  • nikolasburk
  • ankur-arch

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and succinctly summarizes the primary change of updating the TypedSql documentation to include a custom SQL folder location, directly reflecting the core update without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7071f46 and 600195b.

📒 Files selected for processing (1)
  • content/200-orm/200-prisma-client/150-using-raw-sql/100-typedsql.mdx (6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: runner / linkspector
  • GitHub Check: Check internal links
🔇 Additional comments (1)
content/200-orm/200-prisma-client/150-using-raw-sql/100-typedsql.mdx (1)

23-26: Confirm generator provider value.

Can we double-check that provider = "prisma-client" is already accepted by Prisma? The schema reference still documents "prisma-client-js" as the canonical generator value, so please confirm before we publish this change.

@AmanVarshney01 AmanVarshney01 merged commit 90fd931 into prisma:main Oct 13, 2025
7 checks passed
@AmanVarshney01 AmanVarshney01 deleted the aman/typed-sql-custom-sql-folder branch October 13, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants