Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider-aware auto completion is not applied to all auto completions #942

Closed
janpio opened this issue Nov 15, 2021 · 0 comments · Fixed by #1002
Closed

Provider-aware auto completion is not applied to all auto completions #942

janpio opened this issue Nov 15, 2021 · 0 comments · Fixed by #1002
Assignees
@Jolg42
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: autocompletion LSP text document completion
Milestone
3.8.0

Comments

@janpio
Copy link
Contributor

janpio commented Nov 15, 2021

#937 made Restrict disappear from some auto completions, but not all.

More details: https://prisma-company.slack.com/archives/CKCQQGXJM/p1636997912022500
@janpio janpio added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. process/candidate Candidate for next Milestone. topic: autocompletion LSP text document completion domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. labels Nov 15, 2021
@tomhoule tomhoule changed the title Provider-aware auto completion is no applied to all auto completions Provider-aware auto completion is not applied to all auto completions Nov 17, 2021
@tomhoule tomhoule removed the process/candidate Candidate for next Milestone. label Nov 17, 2021
@tomhoule tomhoule added this to the 3.6.0 milestone Nov 17, 2021
@Jolg42 Jolg42 self-assigned this Nov 17, 2021
@Jolg42 Jolg42 modified the milestones: 3.6.0, 3.7.0 Dec 3, 2021
Jolg42 added a commit that referenced this issue Dec 21, 2021
@Jolg42
fix(autocompletion): filter out Restrict for sqlserver
3d6a157 
Closes #942
@Jolg42 Jolg42 mentioned this issue Dec 21, 2021
Merged
@Jolg42 Jolg42 modified the milestones: 3.7.0, 3.8.0 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: autocompletion LSP text document completion
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

fix(autocompletion): filter out Restrict for sqlserver prisma/language-tools
3 participants
@janpio @Jolg42 @tomhoule