Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocompletion): filter out Restrict for sqlserver #1002

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Dec 21, 2021

Closes #942

@Jolg42 Jolg42 added this to the 3.8.0 milestone Dec 21, 2021
@Jolg42 Jolg42 merged commit 9b5cc92 into main Dec 21, 2021
@Jolg42 Jolg42 deleted the joel/fix-restrict-sqlserver branch December 21, 2021 15:57
@janpio
Copy link
Contributor

janpio commented Dec 21, 2021

Would be great if the PR would also require a test update :D

@Jolg42
Copy link
Contributor Author

Jolg42 commented Dec 22, 2021

I have no idea how to test that one at the moment though 😅 It's a different behavior than all the tests we have.

@janpio
Copy link
Contributor

janpio commented Dec 22, 2021

Depending on provider, we expect different auto completions for onUpdate and onDelete?

@Jolg42
Copy link
Contributor Author

Jolg42 commented Dec 22, 2021

@janpio
Copy link
Contributor

janpio commented Dec 22, 2021

But should that test then not have failed before for SQL Server?
Or am I misunderstanding the PR and the issues it fixes?

@Jolg42
Copy link
Contributor Author

Jolg42 commented Dec 22, 2021

I added this "recently" "insertText": "onDelete: ${1|Cascade,Restrict,NoAction,SetNull,SetDefault|}", and this is something we don't know how to test as of today, this PR removed it.

@Jolg42
Copy link
Contributor Author

Jolg42 commented Dec 22, 2021

So now there is only one auto-completion code-path for onDelete/onUpdate

@janpio
Copy link
Contributor

janpio commented Dec 22, 2021

Ok then I don't even understand or know what that does really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider-aware auto completion is not applied to all auto completions
2 participants