Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config variables emitted with marketplace events will now include ID and OAuth status #78

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

taylorreece
Copy link
Member

This prepares embedded for an upcoming change where the INSTANCE_CONFIGURATION_LOADED event will now include config variable id and status (for OAuth connection config variables). The ConnectionConfigVar type already included status, but needed the other properties a config variable has (defined in BaseConfigVar).

@bkegley
Copy link
Contributor

bkegley commented Apr 1, 2024

@taylorreece could you bump the version and npm i to update the lock file?

@taylorreece
Copy link
Member Author

@bkegley - I figure this isn't time-sensitive, and we could get it merged in alongside #79

@bkegley
Copy link
Contributor

bkegley commented Apr 1, 2024

@taylorreece that likely isn't going to merge. Let's just get this out.

@taylorreece taylorreece force-pushed the tr/expose-config-var-id-status branch from 8d86000 to dbd1f2c Compare April 1, 2024 18:09
@taylorreece
Copy link
Member Author

@bkegley 👍 Sounds good. Done!

@taylorreece taylorreece merged commit 0635973 into main Apr 1, 2024
1 check passed
@taylorreece taylorreece deleted the tr/expose-config-var-id-status branch April 1, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants