Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node version & preload iframe conditional #79

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Update node version & preload iframe conditional #79

merged 3 commits into from
Apr 9, 2024

Conversation

jasoncomes
Copy link
Contributor

@jasoncomes jasoncomes commented Mar 29, 2024 •
edited
Loading

  • Update the NodeJS version for the frontend app so that npm linking is possible.
  • Preload iframe script conditional to prevent possible duplication of dom elements.

@taylorreece taylorreece mentioned this pull request Apr 1, 2024
Merged
@jasoncomes jasoncomes force-pushed the jc/frontend-url-param branch 2 times, most recently from 4295f70 to ed6bcaa Compare April 1, 2024 21:55
@jasoncomes jasoncomes changed the title Update NodeJS to 18.18.2 and added a frontendUrl param Update NodeJS to 18.18.2 And Add PrismaticUrl to all methods Apr 1, 2024
@jasoncomes jasoncomes changed the title Update NodeJS to 18.18.2 And Add PrismaticUrl to all methods Add prismaticUrl to all method calls Apr 1, 2024
@jasoncomes jasoncomes force-pushed the jc/frontend-url-param branch 8 times, most recently from 4b1db3a to 25b1468 Compare April 5, 2024 16:45
@jasoncomes jasoncomes changed the title Add prismaticUrl to all method calls Update node version & preload iframe conditional Apr 5, 2024
@jasoncomes jasoncomes requested a review from bkegley April 5, 2024 16:50
bkegley
bkegley approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@bkegley bkegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasoncomes jasoncomes merged commit b0274fa into main Apr 9, 2024
1 check passed
@jasoncomes jasoncomes deleted the jc/frontend-url-param branch April 9, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkegley bkegley bkegley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasoncomes @bkegley