Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse unknown metadata and write metadata #1

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

jessa0
Copy link

@jessa0 jessa0 commented Jan 22, 2023

This is a duplicate of alfg#91 for internal review.

The meta box is very open-ended, leaving itself open to extension by future specs. This PR:

  1. parses the Hdlrbox as required by the spec for the meta box
  2. only parses iTunes metadata when the handler type is mdir (as seen in `big_buck_bunny_metadata.m4v)
  3. makes MetaBox into an enum, to allow for other handlers in the future (like requested in question: MOV Quicktime and MP4 metadata alfg/mp4-rust#66)
  4. allows parsing MetaBox in more positions as per the spec
  5. writes metadata out if present

@jessa0 jessa0 self-assigned this Jan 22, 2023
@jessa0 jessa0 merged commit 3542801 into unknown-meta Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants