fix: upgrade esbuild to 0.24.0 address various issues #669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this project!
Read and understood the reason behind closing another PR . But I would still like to submit this one because:
esbuild
in our ownpackage.json
to work around them, but user experience suffers, especially have impact to new users oftsx
who also care about vulnerabilities.esbuild
release is no longer withbreaking change
label.esbuild-wasm
crash coming from a bug inmemchr
update go 1.22.5 => 1.23.0 evanw/esbuild#3902useDefineForClassFields: false
evanw/esbuild#3913)To be honest, none of them alone solves a critical problem of
tsx
itself but I hope with all together makes the impact bigger.We all understand it is a good practice to keep dependencies up to date to a certain level with cautiousness. Comparing to big version jumps, I think smaller incremental hips is less risky for long run, although brings a bit of more work to do from maintainers' point of view.