Fix frontend artifacts directory in pyproject.toml #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for ./frontend
File CoverageNo changed files found. |
augustebaum
approved these changes
Sep 17, 2024
thomass-dev
added a commit
that referenced
this pull request
Dec 2, 2024
Fixes an issue where the static directory where the frontend build is placed was not the one declared explicitly in the `pyproject.toml`. The frontend build directory was moved from `skore/src/dashboard/static/` to `skore/src/ui/static` during #325 and the change was not made in `pyproject.toml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the static directory where the frontend build is placed was not the one declared explicitly in the
pyproject.toml. The frontend build directory was moved fromskore/src/dashboard/static/toskore/src/ui/staticduring #325 and the change was not made inpyproject.toml.