Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Store to Project #325

Merged
merged 74 commits into from
Sep 17, 2024
Merged

Refactor Store to Project #325

merged 74 commits into from
Sep 17, 2024

Conversation

rouk1
Copy link
Contributor

@rouk1 rouk1 commented Sep 10, 2024 •
edited by augustebaum
Loading

No description provided.

@rouk1 @thomass-dev @augustebaum
Squashed commit of the following:
fb43de6 
commit 2360041
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 17:41:49 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/components/DataStoreCanvas.vue

commit 1747261
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 17:37:23 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/components/DataStoreKeyList.vue

commit 0b7db29
Author: Auguste Baum <auguste@probabl.ai>
Date:   Tue Sep 10 15:54:50 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/stores/useReportStore.ts

commit f3c2fa5
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 15:34:17 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/dashboard/app.py

commit c73c6c5
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 15:31:48 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/api/routes/stores.py

commit d0b25e7
Author: Auguste Baum <auguste@probabl.ai>
Date:   Tue Sep 10 14:57:37 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/components/DataStoreCanvas.vue

commit 7ab364e
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 14:42:19 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/views/ReportBuilderView.vue

commit 3d1c28c
Author: Thomas S <thomas@probabl.ai>
Date:   Tue Sep 10 14:23:58 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/stores/reports.ts

commit a0c50c5
Author: Thomas S <thomas@probabl.ai>
Date:   Tue Sep 10 14:04:05 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/dashboard/app.py

commit 7d630b4
Author: Auguste Baum <auguste@probabl.ai>
Date:   Tue Sep 10 12:08:48 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:frontend/src/models.ts

commit e97a382
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 11:32:53 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/dashboard/app.py

commit 3285335
Author: Auguste Baum <auguste@probabl.ai>
Date:   Tue Sep 10 11:11:11 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 5327ec7
Author: Thomas S <thomas@probabl.ai>
Date:   Tue Sep 10 10:54:46 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/api/routes/stores.py

commit e20ec3c
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Tue Sep 10 10:22:11 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/dashboard/dashboard.py

commit 03090de
Author: Auguste Baum <auguste@probabl.ai>
Date:   Tue Sep 10 10:05:59 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 5b4e4e6
Author: Thomas S <thomas@probabl.ai>
Date:   Tue Sep 10 09:51:05 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/api/routes/stores.py

commit 5debda4
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 17:45:22 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 29e3ba4
Author: Thomas S <thomas@probabl.ai>
Date:   Mon Sep 9 17:30:14 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/storage/non_persistent_storage.py

commit f10e5c6
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 17:19:16 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 2fe46bc
Author: Auguste Baum <auguste@probabl.ai>
Date:   Mon Sep 9 17:03:47 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 3ae7900
Author: Thomas S <thomas@probabl.ai>
Date:   Mon Sep 9 16:48:14 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit 4f2b7f0
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 16:15:38 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit de4fdad
Author: Auguste Baum <auguste@probabl.ai>
Date:   Mon Sep 9 15:58:17 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 55c761b
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 15:39:09 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 5741248
Author: Thomas S <thomas@probabl.ai>
Date:   Mon Sep 9 15:22:49 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit 0c8f7f5
Author: Auguste Baum <auguste@probabl.ai>
Date:   Mon Sep 9 14:59:43 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 29ea203
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 14:43:22 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 373377b
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 12:24:06 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit cf63bef
Author: Thomas S <thomas@probabl.ai>
Date:   Mon Sep 9 12:08:40 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit acf2763
Author: Auguste Baum <auguste@probabl.ai>
Date:   Mon Sep 9 11:43:45 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit c648fdb
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Mon Sep 9 11:23:46 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit f627423
Author: Thomas S <thomas@probabl.ai>
Date:   Mon Sep 9 10:51:13 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit 8a139f2
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Fri Sep 6 18:34:14 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit 316150a
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Fri Sep 6 18:00:12 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 6fcb488
Author: Auguste Baum <auguste@probabl.ai>
Date:   Fri Sep 6 17:43:24 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit e5c1489
Author: Thomas S <thomas@probabl.ai>
Date:   Fri Sep 6 17:27:21 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit 2afb569
Author: Matthieu Jouis <matthieu@probabl.ai>
Date:   Fri Sep 6 17:12:18 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit db49eb5
Author: Thomas S <thomas@probabl.ai>
Date:   Fri Sep 6 16:54:08 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit 2e589f7
Author: Thomas S <thomas@probabl.ai>
Date:   Fri Sep 6 16:53:25 2024 +0200

    mob start [ci-skip] [ci skip] [skip ci]

Co-authored-by: Thomas S <thomas@probabl.ai>
Co-authored-by: Auguste Baum <auguste@probabl.ai>
@rouk1 rouk1 linked an issue Sep 10, 2024 that may be closed by this pull request
Project API #303
Closed
tuscland
tuscland reviewed Sep 11, 2024
View reviewed changes
src/skore/api/routes/stores.py Outdated Show resolved Hide resolved
src/skore/cli.py Outdated Show resolved Hide resolved
src/skore/dashboard/app.py Outdated Show resolved Hide resolved
src/skore/project.py Outdated Show resolved Hide resolved
src/skore/project.py Outdated Show resolved Hide resolved
src/skore/storage/filesystem.py Outdated Show resolved Hide resolved
src/skore/storage/filesystem.py Outdated Show resolved Hide resolved
src/skore/storage/filesystem.py Outdated Show resolved Hide resolved
src/skore/storage/filesystem.py Outdated Show resolved Hide resolved
src/skore/storage/storage.py Outdated Show resolved Hide resolved
@thomass-dev thomass-dev requested review from thomass-dev and removed request for thomass-dev September 11, 2024 08:24
@thomass-dev @augustebaum
Squashed commit of the following:
74007d0 
commit 6b4f6f0
Author: Auguste Baum <auguste@probabl.ai>
Date:   Wed Sep 11 12:23:18 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 33f3ef9
Author: Thomas S <thomas@probabl.ai>
Date:   Wed Sep 11 12:14:58 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 4fb5052
Author: Auguste Baum <auguste@probabl.ai>
Date:   Wed Sep 11 11:58:44 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit d8e54c3
Author: Thomas S <thomas@probabl.ai>
Date:   Wed Sep 11 11:40:56 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit edbc62b
Author: Auguste Baum <auguste@probabl.ai>
Date:   Wed Sep 11 11:21:19 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:src/skore/project.py

commit d6df45c
Author: Thomas S <thomas@probabl.ai>
Date:   Wed Sep 11 11:05:13 2024 +0200

    mob next [ci-skip] [ci skip] [skip ci]

    lastFile:tests/unit/test_project.py

commit 9fa640d
Author: Auguste Baum <auguste@probabl.ai>
Date:   Wed Sep 11 10:43:39 2024 +0200

    mob start [ci-skip] [ci skip] [skip ci]

Co-authored-by: Auguste Baum <auguste@probabl.ai>
rouk1 and others added 15 commits September 11, 2024 15:28
@rouk1
renable sharing feature
e58d4b9
@rouk1
hide used keys from the left pane
e6eb35d
@augustebaum @thomass-dev
mob done
fe8744e 
- Renamed "directory" to "project_name"
- Check whether project exists in `load` and `storage.FileSystem`

Co-authored-by: Thomas S <thomas@probabl.ai>
@rouk1
tidy web app file layout
a8489cc
@augustebaum
various refactorings
7dd1f7a 
- add type `PersistedItem`
- rename `serialize` to `object_to_item`
- rename `deserialize` to `unpersist`
- add `persist` method
- fix makefile
@rouk1
web app: fix 404 on all routes + test endpoints
ebf2a1c
@rouk1
matplot lib figure support
a107bee
@augustebaum
fix test_version
038fa3e
@augustebaum
fix errors in tests
2a00f8b
@augustebaum
fix test_get_report
9a4c3f3
@augustebaum
remove test_list_stores
10b38f7
@augustebaum
fix test_launch
fc9c50d
@augustebaum
remove test_share
8b3d91e
@augustebaum
remove test_get_store_by_uri
a682f6f
@augustebaum
remove test_put_layout
8f64a7c
@augustebaum
Fix error handling in project.load
cfde6a1 
The previous error was inaccurate: it reported that the project
directory itself didn't exist, whereas the real error is that it was
missing some internal directory.
@augustebaum
Reorder __launch
b9d8bc8 
For example, this fixes an issue where the browser is opened even when
the project loading failed.
@augustebaum
replace os.mkdir with Path.mkdir
3eed972
@augustebaum
Separate creation of nested project directories from creation of project
97cbcf7 
This fixes a wrong error message in `__create`
@augustebaum
Use rich.traceback only if skore is used through CLI
7a318b6
@rouk1 rouk1 marked this pull request as draft September 16, 2024 11:51
@augustebaum
Merge branch 'main' into 303-project-api
7b33835
@augustebaum
Update example notebook
32be187 
Add jupytext-synced Python script
@augustebaum
Update Readme
452a045 
Move "Help with common issues" section to CONTRIBUTING.md.
@augustebaum
Fix notebook HTML
43b3f44
@augustebaum
Move global logger to its own file
e384297
@augustebaum
Revert "Move global logger to its own file"
1baa2a9 
This reverts commit e384297.

This is because we need a logger in `skore.__init__` so that logging settings can be manipulated once for the whole package (e.g. setting the log level to ERROR).
@augustebaum
Fix HTML in example notebook (ipynb)
9e77191
@augustebaum
Add CLI-specific logger
ef694a0
tuscland
tuscland requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@tuscland tuscland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big step forward, and more lines removed than added. Well done!

src/skore/project.py Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
notebooks/basic_usage.py Outdated Show resolved Hide resolved
src/skore/cli/create_project.py Outdated Show resolved Hide resolved
src/skore/cli/launch_dashboard.py Show resolved Hide resolved
src/skore/cli/launch_dashboard.py Outdated Show resolved Hide resolved
@augustebaum
Update skrub_demo test notebook
190b5e0
@augustebaum
Address PR feedback
48cd4d9 
- Update Readme
- Change "dashboard" by something else as much as possible
- Replace Google Drive link by GitHub Gist
@augustebaum
Remove "project.skore" argument from readme
937e343
@augustebaum augustebaum marked this pull request as ready for review September 17, 2024 08:28
@tuscland tuscland merged commit 8c70941 into main Sep 17, 2024
1 check passed
@tuscland tuscland deleted the 303-project-api branch September 17, 2024 09:37
@tuscland tuscland mentioned this pull request Sep 17, 2024
Closed
@augustebaum augustebaum mentioned this pull request Sep 17, 2024
Merged
augustebaum pushed a commit that referenced this pull request Sep 17, 2024
@thomass-dev
Fix frontend artifacts directory in pyproject.toml (#343)
a2d6de7 
Fixes an issue where the static directory where the frontend build is
placed was not the one declared explicitly in the `pyproject.toml`. The
frontend build directory was moved from `skore/src/dashboard/static/` to
`skore/src/ui/static` during #325 and the change was not made in
`pyproject.toml`.
thomass-dev added a commit that referenced this pull request Dec 2, 2024
@rouk1 @thomass-dev @augustebaum
Refactor Store to Project (#325)
a674276 
Co-authored-by: Thomas S <thomas@probabl.ai>
Co-authored-by: Auguste Baum <auguste@probabl.ai>
thomass-dev added a commit that referenced this pull request Dec 2, 2024
@thomass-dev
Fix frontend artifacts directory in pyproject.toml (#343)
4c089e3 
Fixes an issue where the static directory where the frontend build is
placed was not the one declared explicitly in the `pyproject.toml`. The
frontend build directory was moved from `skore/src/dashboard/static/` to
`skore/src/ui/static` during #325 and the change was not made in
`pyproject.toml`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustebaum augustebaum augustebaum left review comments

@thomass-dev thomass-dev thomass-dev left review comments

@tuscland tuscland tuscland approved these changes

Assignees

@rouk1 rouk1

@thomass-dev thomass-dev

@augustebaum augustebaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project API
4 participants
@rouk1 @thomass-dev @tuscland @augustebaum