-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move python code to its own directory #440
chore: Move python code to its own directory #440
Conversation
thomass-dev
commented
Oct 4, 2024
•
edited
Loading
edited
f42b9da
to
afcfa0e
Compare
Coverage Report for ./skore-ui
File CoverageNo changed files found. |
4d524aa
to
523280a
Compare
523280a
to
7efa77a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to avoid symbolic links for the readme & licence files.
They are both repo wide and are not related only to the python side of things.
Side note: I like the actual layout but maybe we could have assume the "classic" monorepo layout by adding a packages folder.
The question of the symbolic links is right (i hesitated for a long time): if we want to include a README and a license file in the python distribution package, we need to place them inside the python directory. There can't be outside the directory (ie I assumed we wouldn't duplicated those file, so i made symlinks. Should we ? |
Can't they be copied at build of the release ? |
7326541
to
22a1bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove symbolic links : )
22a1bcb
to
ca45c47
Compare
…`skore/` after #440 (#545) We can see in #541 that pre-commit doesn't execute ruff: ![image](https://github.com/user-attachments/assets/3822a0e6-ca08-43a8-934b-0c417d6d7b6e) Now: ![image](https://github.com/user-attachments/assets/c89394dd-5c8c-49d5-ba67-e05724505608)
``` . ├── CONTRIBUTING.md ├── LICENSE ├── Makefile ├── README.md ├── examples │ ├── basic_usage.ipynb │ ├── basic_usage.py │ ├── README.txt │ ├── skrub_demo.ipynb │ └── skrub_demo.py ├── skore │ ├── pyproject.toml │ ├── requirements-test.txt │ ├── requirements-tools.txt │ ├── requirements.txt │ ├── VERSION.txt │ ├── src │ └── tests └── skore-ui ├── index.html ├── package.json ├── package-lock.json ├── README.md ├── tsconfig.app.json ├── tsconfig.json ├── tsconfig.node.json ├── tsconfig.vitest.json ├── vite.config.lib.ts ├── vite.config.ts ├── vitest.config.ts ├── vitest.setup.ts ├── node_modules ├── public ├── src └── tests ```
…`skore/` after #440 (#545) We can see in #541 that pre-commit doesn't execute ruff: ![image](https://github.com/user-attachments/assets/3822a0e6-ca08-43a8-934b-0c417d6d7b6e) Now: ![image](https://github.com/user-attachments/assets/c89394dd-5c8c-49d5-ba67-e05724505608)